You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/18 12:31:26 UTC
[GitHub] [skywalking] Cool-Coding opened a new issue, #8904: Possible bug fix: redundant `shade.package` property
Cool-Coding opened a new issue, #8904:
URL: https://github.com/apache/skywalking/issues/8904
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
There are `shade.package` properties in the path `apm-sniffer/pom.xml` and `apm-sniffer/apm-agent-core/pom.xml`. I am not sure whether `shade.package` should only be defined in `apm-sniffer/pom.xml`.
`<shade.package>org.apache.skywalking.apm.dependencies</shade.package>`
### What you expected to happen
if this is a bug, I will remove the `shade.package` property in `apm-sniffer/apm-agent-core/pom.xml`.
### How to reproduce
Take a look at `apm-sniffer/apm-agent-core/pom.xml` and `apm-sniffer/pom.xml`.
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Cool-Coding commented on issue #8904: Possible bug fix: redundant `shade.package` property
Posted by GitBox <gi...@apache.org>.
Cool-Coding commented on issue #8904:
URL: https://github.com/apache/skywalking/issues/8904#issuecomment-1101436786
> Oh, you are just saying `<shade.package>org.apache.skywalking.apm.dependencies</shade.package>`. I thought you were talking about the shade plugin. Sorry.
>
> Yes, these are duplicated, it was there due to a legacy reason because we didn't have separate `plugins` jars. They were in the agent.jar as a whole in the past(before 3.x I think?)
>
> If you want to remove one, feel free to do. For me, it is a beauty proof of being a long history project. :)
>
> Do what you need to do, thanks for checking the codes carefully.
Ok，I will submit a PR tomorrow. Thank you for letting me learn about the agent history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8904: Possible bug fix: redundant `shade.package` property
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8904:
URL: https://github.com/apache/skywalking/issues/8904#issuecomment-1101380421
I don't check this for years, but I remember once you removed one, the codes have issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Cool-Coding closed issue #8904: Possible bug fix: redundant `shade.package` property
Posted by GitBox <gi...@apache.org>.
Cool-Coding closed issue #8904: Possible bug fix: redundant `shade.package` property
URL: https://github.com/apache/skywalking/issues/8904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Cool-Coding commented on issue #8904: Possible bug fix: redundant `shade.package` property
Posted by GitBox <gi...@apache.org>.
Cool-Coding commented on issue #8904:
URL: https://github.com/apache/skywalking/issues/8904#issuecomment-1101399612
> I don't check this for years, but I remember once you removed one, the codes have issues.
@wu-sheng It won't cause codes issues. I verified it just now in my local computer using command `mvn clean package`.
Also, I looked at the shaded package in `apm-agent-core.jar`, the `shade.package` have worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8904: Possible bug fix: redundant `shade.package` property
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8904:
URL: https://github.com/apache/skywalking/issues/8904#issuecomment-1101423086
Oh, you are just saying `<shade.package>org.apache.skywalking.apm.dependencies</shade.package>`. I thought you were talking about the shade plugin. Sorry.
Yes, these are duplicated, it was there due to a legacy reason because we didn't have separate `plugins` jars. They were in the agent.jar as a whole in the past(before 3.x I think?)
If you want to remove one, feel free to do. For me, it is a beauty proof of being a long history project. :)
Do what you need to do, thanks for checking the codes carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] Cool-Coding closed issue #8904: Possible bug fix: redundant `shade.package` property
Posted by GitBox <gi...@apache.org>.
Cool-Coding closed issue #8904: Possible bug fix: redundant `shade.package` property
URL: https://github.com/apache/skywalking/issues/8904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org