You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Yifan Gu <yi...@mesosphere.io> on 2014/06/16 22:47:47 UTC
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:47 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Summary (updated)
-----------------
MESOS-1312: Added orphan_tasks and unregistered_frameworks in state.json
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["unreregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Haven't done the WebUI js part.
Thanks,
Yifan Gu
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review45827
-----------------------------------------------------------
src/tests/master_tests.cpp
<https://reviews.apache.org/r/22223/#comment80817>
Add EXPECT_CALL(exec, registered) to eliminate gmock warnings.
- Yifan Gu
On June 16, 2014, 8:47 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 8:47 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["unreregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Haven't done the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/#review45829
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 16, 2014, 8:56 p.m., Yifan Gu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22223/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 8:56 p.m.)
>
>
> Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
>
>
> Bugs: MESOS-1312
> https://issues.apache.org/jira/browse/MESOS-1312
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
> but do not belong to any already (re-)registered frameworks.
>
>
> Diffs
> -----
>
> src/master/http.cpp b565dc6
> src/tests/master_tests.cpp 34df121
>
> Diff: https://reviews.apache.org/r/22223/diff/
>
>
> Testing
> -------
>
> Added MasterTest.OrphanTasks to test:
> 1, Before the framework re-registers with the master:
> Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
> That frameworks will appear in the ["unreregistered_frameworks"] field.
> 2, After the framework re-registers with the master:
> There will be no more orphan tasks and not-yet-reregistered frameworks.
> 3, Haven't done the WebUI js part.
>
>
> Thanks,
>
> Yifan Gu
>
>
Re: Review Request 22223: MESOS-1312: Added orphan_tasks and
unregistered_frameworks in state.json
Posted by Yifan Gu <yi...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22223/
-----------------------------------------------------------
(Updated June 16, 2014, 8:56 p.m.)
Review request for mesos, Adam B, Niklas Nielsen, Ross Allen, and Vinod Kone.
Changes
-------
Elimiated uninterested call warnings.
Bugs: MESOS-1312
https://issues.apache.org/jira/browse/MESOS-1312
Repository: mesos-git
Description
-------
Added orphan_tasks and unregistered_frameworks in state.json to display tasks that are currently running on the slaves,
but do not belong to any already (re-)registered frameworks.
Diffs (updated)
-----
src/master/http.cpp b565dc6
src/tests/master_tests.cpp 34df121
Diff: https://reviews.apache.org/r/22223/diff/
Testing
-------
Added MasterTest.OrphanTasks to test:
1, Before the framework re-registers with the master:
Tasks that belongs to that frameworks will appear in the ["orphan_tasks"] field.
That frameworks will appear in the ["unreregistered_frameworks"] field.
2, After the framework re-registers with the master:
There will be no more orphan tasks and not-yet-reregistered frameworks.
3, Haven't done the WebUI js part.
Thanks,
Yifan Gu