[GitHub] [pulsar] addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options

[GitBox <gi...@apache.org>]

addisonj commented on a change in pull request #5400: [functions] Allow functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344412884
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
 ##########
 @@ -151,7 +151,7 @@ public FunctionRuntimeManager(WorkerConfig workerConfig, WorkerService workerSer
         }
         secretsProviderConfigurator.init(workerConfig.getSecretsProviderConfiguratorConfig());
 
-        Optional<FunctionAuthProvider> functionAuthProvider = Optional.empty();
 
 Review comment:
   Because we now allow namespaces to be overridden by the ManifestCustomizer, we end up with an authprovider class being created per function, as the authProvider might be writing creds to different namespaces depending on the function. We do that by delaying the instantiation of the AuthProvider until we have the function details, so we just pass the classname into runtime providers. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services