You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2022/01/30 17:45:59 UTC
[orc] branch branch-1.7 updated: ORC-1105: fetch-data.sh should use zsh instead of bash (#1031)
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.7 by this push:
new fdee6a3 ORC-1105: fetch-data.sh should use zsh instead of bash (#1031)
fdee6a3 is described below
commit fdee6a362ad73733337d7599ce8b1a6b75ee3b15
Author: William Hyun <wi...@apache.org>
AuthorDate: Sun Jan 30 09:45:20 2022 -0800
ORC-1105: fetch-data.sh should use zsh instead of bash (#1031)
### What changes were proposed in this pull request?
This PR aims to use zsh in `fetch-data.sh` instead of bash.
### Why are the changes needed?
`bash` has a different behavior in `MacOS` environment. `zsh` works like Linux bash.
```
$ bash -c "echo {01..15}"
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
$ zsh -c "echo {01..15}"
01 02 03 04 05 06 07 08 09 10 11 12 13 14 15
$ docker run -it --rm ubuntu bash -c 'echo {01..15}'
01 02 03 04 05 06 07 08 09 10 11 12 13 14 15
```
### How was this patch tested?
Manually test by running `fetch-data.sh` on MacOS.
(cherry picked from commit 6500b3ca878f90e5f9d66809dca2f0dbcf885ee9)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
java/bench/fetch-data.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/bench/fetch-data.sh b/java/bench/fetch-data.sh
index 2b476b8..e43fcf4 100755
--- a/java/bench/fetch-data.sh
+++ b/java/bench/fetch-data.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env zsh
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information