You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/02 17:39:47 UTC

[GitHub] haojin2 opened a new pull request #12004: Fix flaky test_quantization.test_get_optimal_thresholds

haojin2 opened a new pull request #12004: Fix flaky test_quantization.test_get_optimal_thresholds
URL: https://github.com/apache/incubator-mxnet/pull/12004
 
 
   ## Description ##
   Fix for #11456.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Changed dtype of input and raised tolerance level
   
   ## Comments ##
   Passed 10000 times on CPU:
   ```
   python tools/flakiness_checker.py test_quantization.test_get_optimal_thresholds -n 10000
   INFO:root:Testing: /home/ubuntu/incubator-mxnet/tests/python/quantization/test_quantization.py:test_get_optimal_thresholds
   INFO:root:No test seed provided, using random seed
   /home/ubuntu/anaconda3/lib/python3.6/site-packages/urllib3/contrib/pyopenssl.py:46: DeprecationWarning: OpenSSL.rand is deprecated - you should use os.urandom instead
     import OpenSSL.SSL
   test_quantization.test_get_optimal_thresholds ... ok
   
   ----------------------------------------------------------------------
   Ran 1 test in 66564.359s
   
   OK
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services