[GitHub] [airflow] Taragolis commented on a diff in pull request #29496: Fix log tailing issues with legacy log view

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #29496:
URL: https://github.com/apache/airflow/pull/29496#discussion_r1107119708


##########
airflow/www/views.py:
##########
@@ -1527,7 +1527,15 @@ def get_logs_with_metadata(self, session=None):
 
         ti = (
             session.query(models.TaskInstance)
-            .filter_by(dag_id=dag_id, task_id=task_id, execution_date=execution_date, map_index=map_index)
+            .filter(
+                TaskInstance.task_id == task_id,
+                TaskInstance.dag_id == dag_id,
+                TaskInstance.execution_date == execution_date,
+                TaskInstance.map_index == map_index,

Review Comment:
   Ohhhh... This view still use `execution_date` instead of `run_id` (not related to this PR)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org