You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/08/12 05:48:02 UTC
[GH] (texera/main): Workflow run "Direct Backport Push" is working again!
The GitHub Actions job "Direct Backport Push" on texera.git/main has succeeded.
Run started by GitHub user github-merge-queue[bot] (triggered by github-merge-queue[bot]).
Head commit for run:
5021bc6f1a96d00cb26aa9c3a82c86fee67da0a9 / Xinyuan Lin <xi...@uci.edu>
test(frontend): click the toolbar buttons rather than calling their handlers (#7547)
### What changes were proposed in this PR?
The suite calls the handlers directly, which is not the same thing:
coverage for `(click)="onClickX()"` lands on the generated listener
body, so a button wired to the wrong handler — or to none — looks
perfectly tested today.
Adds 2 tests that click the real elements. The first is table-driven
over six visually near-identical icon buttons, since a copy-paste
leaving two of them on the same handler is the realistic defect. The
second asserts the converse: clicking auto-layout must not also reset
the panels.
**Verified by mutation**, all reverted (template diff empty):
| Mutation | Result |
|---|---|
| auto layout wired to reset panels | red |
| close panels wired to reset panels | red |
| generate report unwired | red |
| reset zoom wired to auto layout | red |
| add comment unwired | red |
| reset panels wired to close panels | red |
### Deliberately not included
The four display switches live in the `#executionSettings` popover,
which ng-zorro instantiates into a CDK overlay only on open. Opening the
first `NzPopoverDirective` on the page yields one switch, not four —
locating the right one needs more overlay plumbing than four lines
justify. They remain uncovered, and the issue records how to reach them.
No production file is touched.
### Any related issues, documentation, discussions?
Closes #7546
### How was this PR tested?
```
npx ng test --watch=false --include="**/menu.component.spec.ts"
```
```
Test Files 1 passed (1)
Tests 83 passed (83)
```
2 new on top of the existing 81. `yarn format:ci` passes.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
Report URL: https://github.com/apache/texera/actions/runs/31567729510
With regards,
GitHub Actions via GitBox