You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "pdxcodemonkey (GitHub)" <gi...@apache.org> on 2018/10/16 20:29:21 UTC

[GitHub] [geode-native] pdxcodemonkey opened pull request #380: GEODE-5746: deflakify cli integration test2

- Refactor integration-test-2 framework for CLI to work like the C++ framework (mostly)
- Make DataSerializable Cq test work again with new framework
- verify tests pass in parallel and clean up after themselves properly when done


[ Full content available at: https://github.com/apache/geode-native/pull/380 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] echobravopapa commented on pull request #380: GEODE-5746: deflakify cli integration test2

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.

right, that was for very long addresses...

[ Full content available at: https://github.com/apache/geode-native/pull/380 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] mmartell commented on issue #380: GEODE-5746: deflakify cli integration test2

Posted by "mmartell (GitHub)" <gi...@apache.org>.

I love the new builder pattern here. I'll take it on faith that this fixes the problems seen with running these tests in parallel. Even if there are remaining issues it should be much easier to debug with this new design.

[ Full content available at: https://github.com/apache/geode-native/pull/380 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey closed pull request #380: GEODE-5746: deflakify cli integration test2

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.

[ pull request closed by pdxcodemonkey ]

[ Full content available at: https://github.com/apache/geode-native/pull/380 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] moleske commented on pull request #380: GEODE-5746: deflakify cli integration test2

Posted by "moleske (GitHub)" <gi...@apache.org>.

Wait it wasn't supposed to be `getAddddress()` :-p

[ Full content available at: https://github.com/apache/geode-native/pull/380 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org