You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2016/02/26 17:04:50 UTC
Review Request 44074: Authorization for Auto start services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
Bugs: AMBARI-15190
https://issues.apache.org/jira/browse/AMBARI-15190
Repository: ambari
Description
-------
We need to add authorization for Auto start services.
#Solution
- Users with the ability to modify cluster configurations ({{CLUSTER.MODIFY_CONFIGS}}) should be able to toggle the cluster-level auto start value.
- Users with the ability to start and stop services ({{SERVICE.START_STOP}}) should be able to toggle the service-level auto start value.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 0e97e1e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java c624cfd
ambari-web/app/views/main/admin.js 8b9ec03
ambari-web/app/views/main/menu.js b71bbd3
Diff: https://reviews.apache.org/r/44074/diff/
Testing
-------
Manually tested
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 44074: Authorization for Auto start services
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/#review121123
-----------------------------------------------------------
Ship it!
Ship It!
- Swapan Shridhar
On Feb. 26, 2016, 4:05 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 4:05 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
>
>
> Bugs: AMBARI-15190
> https://issues.apache.org/jira/browse/AMBARI-15190
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need to add authorization for Auto start services.
>
> #Solution
> - Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`) should be able to toggle the cluster-level auto start value.
> - Users with the ability to start and stop services (`SERVICE.START_STOP`) should be able to toggle the service-level auto start value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 0e97e1e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java c624cfd
> ambari-web/app/views/main/admin.js 8b9ec03
> ambari-web/app/views/main/menu.js b71bbd3
>
> Diff: https://reviews.apache.org/r/44074/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 44074: Authorization for Auto start services
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/#review120872
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Feb. 26, 2016, 4:05 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 4:05 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
>
>
> Bugs: AMBARI-15190
> https://issues.apache.org/jira/browse/AMBARI-15190
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need to add authorization for Auto start services.
>
> #Solution
> - Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`) should be able to toggle the cluster-level auto start value.
> - Users with the ability to start and stop services (`SERVICE.START_STOP`) should be able to toggle the service-level auto start value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 0e97e1e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java c624cfd
> ambari-web/app/views/main/admin.js 8b9ec03
> ambari-web/app/views/main/menu.js b71bbd3
>
> Diff: https://reviews.apache.org/r/44074/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 44074: Authorization for Auto start services
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/#review121242
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Feb. 29, 2016, 1:22 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44074/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 1:22 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
>
>
> Bugs: AMBARI-15190
> https://issues.apache.org/jira/browse/AMBARI-15190
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need to add authorization for Auto start services.
>
> #Solution
> - Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`) should be able to toggle the cluster-level auto start value.
> - Users with the ability to start and stop services (`SERVICE.START_STOP`) should be able to toggle the service-level auto start value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 03d74a7
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 042c5d4
> ambari-web/app/views/main/admin.js 8b9ec03
> ambari-web/app/views/main/menu.js b71bbd3
>
> Diff: https://reviews.apache.org/r/44074/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:13 min
> [INFO] Finished at: 2016-02-26T19:47:36+00:00
> [INFO] Final Memory: 15M/302M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 44074: Authorization for Auto start services
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 8:22 a.m.)
Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
Bugs: AMBARI-15190
https://issues.apache.org/jira/browse/AMBARI-15190
Repository: ambari
Description
-------
We need to add authorization for Auto start services.
#Solution
- Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`) should be able to toggle the cluster-level auto start value.
- Users with the ability to start and stop services (`SERVICE.START_STOP`) should be able to toggle the service-level auto start value.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 03d74a7
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 042c5d4
ambari-web/app/views/main/admin.js 8b9ec03
ambari-web/app/views/main/menu.js b71bbd3
Diff: https://reviews.apache.org/r/44074/diff/
Testing
-------
Manually tested
# Jenkins test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:13 min
[INFO] Finished at: 2016-02-26T19:47:36+00:00
[INFO] Final Memory: 15M/302M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 44074: Authorization for Auto start services
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/
-----------------------------------------------------------
(Updated Feb. 29, 2016, 8:05 a.m.)
Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
Bugs: AMBARI-15190
https://issues.apache.org/jira/browse/AMBARI-15190
Repository: ambari
Description
-------
We need to add authorization for Auto start services.
#Solution
- Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`) should be able to toggle the cluster-level auto start value.
- Users with the ability to start and stop services (`SERVICE.START_STOP`) should be able to toggle the service-level auto start value.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 0e97e1e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java c624cfd
ambari-web/app/views/main/admin.js 8b9ec03
ambari-web/app/views/main/menu.js b71bbd3
Diff: https://reviews.apache.org/r/44074/diff/
Testing (updated)
-------
Manually tested
# Jenkins test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:13 min
[INFO] Finished at: 2016-02-26T19:47:36+00:00
[INFO] Final Memory: 15M/302M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 44074: Authorization for Auto start services
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/#review120934
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java (line 623)
<https://reviews.apache.org/r/44074/#comment182463>
Can we a description in Javadoc for this?
- Alejandro Fernandez
On Feb. 26, 2016, 4:05 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44074/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 4:05 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
>
>
> Bugs: AMBARI-15190
> https://issues.apache.org/jira/browse/AMBARI-15190
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need to add authorization for Auto start services.
>
> #Solution
> - Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`) should be able to toggle the cluster-level auto start value.
> - Users with the ability to start and stop services (`SERVICE.START_STOP`) should be able to toggle the service-level auto start value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 0e97e1e
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java c624cfd
> ambari-web/app/views/main/admin.js 8b9ec03
> ambari-web/app/views/main/menu.js b71bbd3
>
> Diff: https://reviews.apache.org/r/44074/diff/
>
>
> Testing
> -------
>
> Manually tested
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 44074: Authorization for Auto start services
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44074/
-----------------------------------------------------------
(Updated Feb. 26, 2016, 11:05 a.m.)
Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Swapan Shridhar.
Bugs: AMBARI-15190
https://issues.apache.org/jira/browse/AMBARI-15190
Repository: ambari
Description (updated)
-------
We need to add authorization for Auto start services.
#Solution
- Users with the ability to modify cluster configurations (`CLUSTER.MODIFY_CONFIGS`) should be able to toggle the cluster-level auto start value.
- Users with the ability to start and stop services (`SERVICE.START_STOP`) should be able to toggle the service-level auto start value.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 0e97e1e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java c624cfd
ambari-web/app/views/main/admin.js 8b9ec03
ambari-web/app/views/main/menu.js b71bbd3
Diff: https://reviews.apache.org/r/44074/diff/
Testing
-------
Manually tested
# Jenkins test results: PENDING
Thanks,
Robert Levas