[jira] [Commented] (CARBONDATA-264) Limit query scan time statistics issue

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CARBONDATA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15605718#comment-15605718 ] 

ASF GitHub Bot commented on CARBONDATA-264:
-------------------------------------------

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/184#discussion_r84940346
  
    --- Diff: core/src/main/java/org/apache/carbondata/scan/executor/impl/DetailQueryExecutor.java ---
    @@ -36,6 +36,7 @@
       @Override public CarbonIterator<Object[]> execute(QueryModel queryModel)
           throws QueryExecutionException {
         List<BlockExecutionInfo> blockExecutionInfoList = getBlockExecutionInfos(queryModel);
    +    queryProperties.scanStartTime=System.currentTimeMillis();
    --- End diff --
    
    incorrect code style 


> Limit query scan time statistics issue 
> ---------------------------------------
>
>                 Key: CARBONDATA-264
>                 URL: https://issues.apache.org/jira/browse/CARBONDATA-264
>             Project: CarbonData
>          Issue Type: Bug
>            Reporter: kumar vishal
>            Priority: Minor
>
> Problem: Scan time is not logging in statistics in case of limit query 
> Soluntion: Moved statistics from iterator to queryExecutor finish method as in case of limit query after consuming records call is not coming to hasNext method 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)