[GitHub] [cassandra] adelapena commented on a change in pull request #1342: Cassandra 17169 4.0

[GitBox <gi...@apache.org>]

adelapena commented on a change in pull request #1342:
URL: https://github.com/apache/cassandra/pull/1342#discussion_r758536635



##########
File path: test/unit/org/apache/cassandra/utils/RecomputingSupplierTest.java
##########
@@ -93,31 +89,40 @@ public void recomputingSupplierTest() throws Throwable
                             lastSeen.accumulateAndGet(v, Math::max);
                             Assert.assertTrue(String.format("Seen %d out of order. Last seen value %d", v, seenBeforeGet),
                                               v >= seenBeforeGet);
-
                         }
-
                     }
                     catch (Throwable e)
                     {
                         thrown.set(e);
-                        latch.countDown();
                     }
                 }
             });
         }
 
-        latch.await(10, TimeUnit.SECONDS);
-
+        Util.spinAssertEquals(true, () -> {return counter.get() > 1;}, 11);

Review comment:
       I understand that the purpose of this line is ensuring that the tasks above have had time to update `counter`. The previous incarnation of this line awaited for 10s which is probably too much, but I'm wondering if waiting for a single increase of counter is too little. Maybe we can wait until it has been increased more times, for example:
   ```suggestion
           Util.spinAssertEquals(true, () -> {return counter.get() > 1000;}, 11);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org