[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1300: feat: decide whether two C strings are equal and support CHECK_STREQ* and CHECK_STRNE*

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1300:
URL: https://github.com/apache/incubator-pegasus/pull/1300#discussion_r1052786527


##########
src/shell/commands/global_properties.cpp:
##########
@@ -44,11 +45,11 @@ bool process_escape_all(command_executor *e, shell_context *sc, arguments args)
         fprintf(stderr, "Current escape_all: %s.\n", sc->escape_all ? "true" : "false");
         return true;
     } else if (args.argc == 2) {
-        if (strcmp(args.argv[1], "true") == 0) {
+        if (dsn::utils::equals(args.argv[1], "true")) {

Review Comment:
   Does is make sense if introducing `iequals` to compare strings but ignore cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org