You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/12/21 22:06:01 UTC
[jira] Created: (WHIRR-172) Log warning for unrecognized service
names
Log warning for unrecognized service names
------------------------------------------
Key: WHIRR-172
URL: https://issues.apache.org/jira/browse/WHIRR-172
Project: Whirr
Issue Type: Bug
Reporter: Tom White
Assignee: Tom White
Priority: Critical
Fix For: 0.3.0
We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (WHIRR-172) Log warning for unrecognized service
names
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-172:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I've just committed this. Thanks for the review Andrei - I fixed the star import.
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
> Fix For: 0.5.0
>
> Attachments: WHIRR-172.patch
>
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (WHIRR-172) Log warning for
unrecognized service names
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973913#action_12973913 ]
Lars George edited comment on WHIRR-172 at 12/21/10 4:49 PM:
-------------------------------------------------------------
The error was:
{code}$ bin/whirr launch-cluster --config hbase-cluster.properties
Unable to find service hbase, exiting
Usage: whirr launch-cluster [OPTIONS]
Option Description
------ -----------
--client-cidrs
--cluster-name
--config
--credential
--hardware-id
--identity
--image-id
--instance-templates
--location-id
--private-key-file
--provider
--public-key-file
--run-url-base
--service-name
--version {code}
I also suggest to add "(deprecated)" next to "--service-name" to be safe. And obviously the docs need to be adjusted, at the very latest when this option is dropped.
was (Author: larsgeorge):
The error was:
{code}
$ bin/whirr launch-cluster --config hbase-cluster.properties
Unable to find service hbase, exiting
Usage: whirr launch-cluster [OPTIONS]
Option Description
------ -----------
--client-cidrs
--cluster-name
--config
--credential
--hardware-id
--identity
--image-id
--instance-templates
--location-id
--private-key-file
--provider
--public-key-file
--run-url-base
--service-name
--version
{code}
I also suggest to add "(deprecated)" next to "--service-name" to be save. And obviously the docs need to be adjusted, at the very latest when this option is dropped.
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
> Fix For: 0.3.0
>
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-172) Log warning for unrecognized service
names
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976117#action_12976117 ]
Andrei Savu commented on WHIRR-172:
-----------------------------------
I suggest that we should not change the current behavior because "--service-name" is optional (not deprecated) and if the user specifies an invalid value that should be treated like a fatal error. I have also fixed the docs in WHIRR-181
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
> Fix For: 0.3.0
>
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (WHIRR-172) Log warning for unrecognized service
names
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-172:
----------------------------
Attachment: WHIRR-172.patch
This caught me out as I have a properties file with "whirr.service-name=hadoop" in it, and since WHIRR-245 there are no longer service subclasses for Hadoop, Cassandra, and ZooKeeper.
This patch simply falls back to the default ClusterController, if the named one can't be loaded (after logging a warning).
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
> Fix For: 0.5.0
>
> Attachments: WHIRR-172.patch
>
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-172) Log warning for unrecognized service
names
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-172:
----------------------------
Fix Version/s: 0.5.0
Status: Patch Available (was: Open)
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
> Fix For: 0.5.0
>
> Attachments: WHIRR-172.patch
>
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-172) Log warning for unrecognized service
names
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973913#action_12973913 ]
Lars George commented on WHIRR-172:
-----------------------------------
The error was:
{code}
$ bin/whirr launch-cluster --config hbase-cluster.properties
Unable to find service hbase, exiting
Usage: whirr launch-cluster [OPTIONS]
Option Description
------ -----------
--client-cidrs
--cluster-name
--config
--credential
--hardware-id
--identity
--image-id
--instance-templates
--location-id
--private-key-file
--provider
--public-key-file
--run-url-base
--service-name
--version
{code}
I also suggest to add "(deprecated)" next to "--service-name" to be save. And obviously the docs need to be adjusted, at the very latest when this option is dropped.
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
> Fix For: 0.3.0
>
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-172) Log warning for unrecognized service
names
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-172:
----------------------------
Fix Version/s: (was: 0.3.0)
I don't think this is a blocker for 0.3.0.
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (WHIRR-172) Log warning for unrecognized service
names
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13019815#comment-13019815 ]
Andrei Savu commented on WHIRR-172:
-----------------------------------
+1 before committing you should remove the star import from tests.
> Log warning for unrecognized service names
> ------------------------------------------
>
> Key: WHIRR-172
> URL: https://issues.apache.org/jira/browse/WHIRR-172
> Project: Whirr
> Issue Type: Bug
> Reporter: Tom White
> Assignee: Tom White
> Priority: Critical
> Fix For: 0.5.0
>
> Attachments: WHIRR-172.patch
>
>
> We should log a warning for unrecognized service names rather than failing. This came up in WHIRR-25 where someone specified the service name of "hbase" (by analogy with the other services) and it failed to start.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira