You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2018/02/14 14:46:24 UTC
[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/5489
[FLINK-8652] [QS] Reduce log level in getKvState to DEBUG.
## What is the purpose of the change
Reduce log level in `QueryableStateClient.getKvState()` from `INFO` to `DEBUG`.
## Brief change log
Reduce log level in `QueryableStateClient.getKvState()` from `INFO` to `DEBUG`.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **n/a**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink qstateclient-logs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5489.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5489
----
----
---
[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5489#discussion_r168239560
--- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java ---
@@ -268,7 +268,7 @@ public ExecutionConfig setExecutionConfig(ExecutionConfig config) {
final String queryableStateName,
final int keyHashCode,
final byte[] serializedKeyAndNamespace) {
- LOG.info("Sending State Request to {}.", remoteAddress);
+ LOG.debug("Sending State Request to {}.", remoteAddress);
--- End diff --
I see.
---
[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5489#discussion_r168196728
--- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java ---
@@ -268,7 +268,7 @@ public ExecutionConfig setExecutionConfig(ExecutionConfig config) {
final String queryableStateName,
final int keyHashCode,
final byte[] serializedKeyAndNamespace) {
- LOG.info("Sending State Request to {}.", remoteAddress);
+ LOG.debug("Sending State Request to {}.", remoteAddress);
--- End diff --
alright, will fix and merge it.
---
[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5489
---
[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5489#discussion_r168197563
--- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java ---
@@ -268,7 +268,7 @@ public ExecutionConfig setExecutionConfig(ExecutionConfig config) {
final String queryableStateName,
final int keyHashCode,
final byte[] serializedKeyAndNamespace) {
- LOG.info("Sending State Request to {}.", remoteAddress);
+ LOG.debug("Sending State Request to {}.", remoteAddress);
--- End diff --
actually, it is fine this way.
`LOG.debug()` is overloaded with non-varargs implementations.
---
[GitHub] flink pull request #5489: [FLINK-8652] [QS] Reduce log level in getKvState t...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5489#discussion_r168196028
--- Diff: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/QueryableStateClient.java ---
@@ -268,7 +268,7 @@ public ExecutionConfig setExecutionConfig(ExecutionConfig config) {
final String queryableStateName,
final int keyHashCode,
final byte[] serializedKeyAndNamespace) {
- LOG.info("Sending State Request to {}.", remoteAddress);
+ LOG.debug("Sending State Request to {}.", remoteAddress);
--- End diff --
We should go for:
```
if (LOG.isDebugEnabled) {
....
}
```
---