You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/09/04 13:36:53 UTC
[Bug 5081] New: spamd_hup.t failures due to new kids being started while old ones are being killed
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5081
Summary: spamd_hup.t failures due to new kids being started while
old ones are being killed
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: spamc/spamd
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jm@jmason.org
I noticed quite a few failures of t/spamd_hup.t on a new laptop here. here was
the culprit:
[11632] info: spamd: server hit by SIGHUP, restarting
[11632] dbg: prefork: new lowest idle kid: none
[11632] info: spamd: child 11673 killed successfully
[11632] dbg: prefork: new lowest idle kid: none
[11632] info: spamd: child 11672 killed successfully
[11632] dbg: prefork: child 11672: ignored new state 1, already exited?
[11632] dbg: prefork: child reports idle
[11632] info: prefork: child states:
[11632] dbg: prefork: adjust: increasing, not enough idle children (0 < 1)
[11676] dbg: prefork: sysread(9) not ready, wait max 300 secs
[11632] info: spamd: server successfully spawned child process, pid 11676
a new server shouldn't have been started at that point, since SIGHUP had
been received and the old ones were being killed! after that, obviously
the accept socket was still open, so EADDRINUSE errors were caused.
testing a patch now.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5081] [review] spamd_hup.t failures due to new kids being started while old ones are being killed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5081
------- Additional Comments From jm@jmason.org 2006-09-04 13:18 -------
Created an attachment (id=3682)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3682&action=view)
fix
please vote... sorry about the "noise" indent changes, they were
accidental (but of course harmless)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5081] [review] spamd_hup.t failures due to new kids being started while old ones are being killed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5081
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Summary|spamd_hup.t failures due to |[review] spamd_hup.t
|new kids being started while|failures due to new kids
|old ones are being killed |being started while old ones
| |are being killed
Target Milestone|Undefined |3.1.6
------- Additional Comments From jm@jmason.org 2006-09-04 13:16 -------
fix applied --
Sending lib/Mail/SpamAssassin/SpamdForkScaling.pm
Sending spamd/spamd.raw
Sending t/spamd_hup.t
Transmitting file data ...
Committed revision 440066.
will attach the patch for 3.1...
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5081] [review] spamd_hup.t failures due to new kids being started while old ones are being killed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5081
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |ready to commit
------- Additional Comments From sidney@sidney.com 2006-10-03 16:19 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5081] [review] spamd_hup.t failures due to new kids being started while old ones are being killed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5081
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2006-10-03 16:41 -------
[dos@FC5-VPC 3.1]$ svn ci -m "bug 5081: sometimes, SIGHUPing spamd would leave
one child process still alive due to a race in the SIGHUP handler and the
preforking code. fixed"
Sending lib/Mail/SpamAssassin/SpamdForkScaling.pm
Sending spamd/spamd.raw
Sending t/spamd_hup.t
Transmitting file data ...
Committed revision 452678.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5081] [review] spamd_hup.t failures due to new kids being started while old ones are being killed
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5081
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |needs 1 vote
------- Additional Comments From spamassassin@dostech.ca 2006-09-28 22:23 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.