You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2023/03/10 21:00:09 UTC

[GitHub] [accumulo] EdColeman opened a new pull request, #3234: update wait for tservers to allow infinite wait

EdColeman opened a new pull request, #3234:
URL: https://github.com/apache/accumulo/pull/3234

   Fix issue with allowing infinite wait for tserver count
   
   This is a follow-on and updates PR https://github.com/apache/accumulo/pull/3231 and issue https://github.com/apache/accumulo/issues/3159


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman commented on pull request #3234: update wait for tservers to allow infinite wait

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on PR #3234:
URL: https://github.com/apache/accumulo/pull/3234#issuecomment-1464491613

   I think that trying to use `maxWait(waitPeriod, MILLISECONDS)` when waitPeriod is MAX_LONG would make the time between checks excessively long  - we should continue to poll at a reasonable interval (this code picked 30 seconds as a max)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman commented on pull request #3234: update wait for tservers to allow infinite wait

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman commented on PR #3234:
URL: https://github.com/apache/accumulo/pull/3234#issuecomment-1464524386

   @ddanielr is going to post an alternate instead of this approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ddanielr commented on pull request #3234: update wait for tservers to allow infinite wait

Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on PR #3234:
URL: https://github.com/apache/accumulo/pull/3234#issuecomment-1464493498

   > I think that trying to use `maxWait(waitPeriod, MILLISECONDS)` when waitPeriod is MAX_LONG would make the time between checks excessively long - we should continue to poll at a reasonable interval (this code picked 30 seconds as a max)
   
   Sure, that could be reduced. I believe the original value was 50ms or half of maxWait. 
   The incremental change is what causes the inaccuracy for defined startup timeouts. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ddanielr commented on pull request #3234: update wait for tservers to allow infinite wait

Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on PR #3234:
URL: https://github.com/apache/accumulo/pull/3234#issuecomment-1464486152

   Given that the intervals just need to be changed, wouldn't just changing the number of retries and the increment variable accomplish that without redoing the logic? 
   
   ```
       long retries = 10;
       long waitPeriod = maxWait / retries;
       long waitIncrement = 0;
       
       if (maxWait <= 0) {
         log.info("tserver availability check set to block indefinitely, To change, set {} > 0.",
             Property.MASTER_STARTUP_TSERVER_AVAIL_MAX_WAIT.getKey());
         maxWait = Long.MAX_VALUE;
         
         // Change retry logic for incremental backoff and logging due to indefinite blocking
         retries = maxWait;
         waitPeriod = maxWait;
         waitIncrement = 15_000;
       }
    ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] EdColeman closed pull request #3234: update wait for tservers to allow infinite wait

Posted by "EdColeman (via GitHub)" <gi...@apache.org>.
EdColeman closed pull request #3234: update wait for tservers to allow infinite wait
URL: https://github.com/apache/accumulo/pull/3234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #3234: update wait for tservers to allow infinite wait

Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on PR #3234:
URL: https://github.com/apache/accumulo/pull/3234#issuecomment-1464586674

   #3235 supersedes this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org