You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/09/10 19:15:56 UTC

[GitHub] mdeuser commented on a change in pull request #2675: Added changes for classes and variables casing to be get exported and can be used in other places

mdeuser commented on a change in pull request #2675: Added changes for classes and variables casing to be get exported and can be used in other places
URL: https://github.com/apache/incubator-openwhisk/pull/2675#discussion_r137957618
 
 

 ##########
 File path: tools/cli/go-whisk/whisk/client.go
 ##########
 @@ -254,6 +260,12 @@ func bodyTruncator(body io.ReadCloser) (string, io.ReadCloser, error) {
 func (c *Client) Do(req *http.Request, v interface{}, ExitWithErrorOnTimeout bool) (*http.Response, error) {
     var err error
     var truncatedBody string
+    obfuscateArr := []ObfuscateSet{
 
 Review comment:
   @jessealva Let's also enable this array to be configured by the user of this http client module.  that is, if the caller knows that it expects a one or more sensitive strings to be part of either the request or response, then the caller will add these sensitive strings to this array so that they are replace anywhere in the output. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services