You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@casbin.apache.org by "cooronx (via GitHub)" <gi...@apache.org> on 2026/04/15 14:30:38 UTC
[PR] feat: remove tracking scripts [casbin-website]
cooronx opened a new pull request, #467:
URL: https://github.com/apache/casbin-website/pull/467
part of #460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@casbin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@casbin.apache.org
For additional commands, e-mail: commits-help@casbin.apache.org
Re: [PR] feat: remove tracking scripts [casbin-website]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #467:
URL: https://github.com/apache/casbin-website/pull/467#discussion_r3087362010
##########
docusaurus.config.js:
##########
@@ -328,27 +328,10 @@ var _hmt = _hmt || [];
},
},
},
- scripts: [
- {
- src: "/js/hotjar.js",
- async: true,
- },
- {
- src: "/js/probe.js",
- async: true,
- },
- {
- src: "/js/clarity.js",
- async: true,
- },
- ],
presets: [
[
"@docusaurus/preset-classic",
{
Review Comment:
PR title/intent is to remove tracking scripts, but the site still injects Baidu analytics via an inline <script> in the footer (hm.baidu.com). If the goal is to remove tracking, this should be removed/disabled as well; otherwise the PR title/description should be adjusted to reflect the remaining analytics dependency.
##########
docusaurus.config.js:
##########
@@ -328,27 +328,10 @@ var _hmt = _hmt || [];
},
},
},
- scripts: [
- {
- src: "/js/hotjar.js",
- async: true,
- },
- {
- src: "/js/probe.js",
- async: true,
- },
- {
- src: "/js/clarity.js",
- async: true,
- },
- ],
presets: [
[
"@docusaurus/preset-classic",
{
Review Comment:
The PR description says this is part of #460 (ASF incubation compliance notice + “make it all Green”), but this diff only removes analytics scripts and doesn't address the incubation/footer styling requirements. Please either update the PR description/linkage or include the #460-required changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@casbin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@casbin.apache.org
For additional commands, e-mail: commits-help@casbin.apache.org
Re: [PR] feat: remove tracking scripts [casbin-website]
Posted by "hsluoyz (via GitHub)" <gi...@apache.org>.
hsluoyz merged PR #467:
URL: https://github.com/apache/casbin-website/pull/467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@casbin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@casbin.apache.org
For additional commands, e-mail: commits-help@casbin.apache.org