You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-dev@hadoop.apache.org by "Milind Bhandarkar (JIRA)" <ji...@apache.org> on 2007/01/30 23:52:33 UTC

[jira] Commented: (HADOOP-959) TestCheckpoint fails on Windows

    [ https://issues.apache.org/jira/browse/HADOOP-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468812 ] 

Milind Bhandarkar commented on HADOOP-959:
------------------------------------------

The comments "//renameTo fails on windows" should be more descriptive, e.g. // renameTo fails on windows if the destination exists

> TestCheckpoint fails on Windows
> -------------------------------
>
>                 Key: HADOOP-959
>                 URL: https://issues.apache.org/jira/browse/HADOOP-959
>             Project: Hadoop
>          Issue Type: Bug
>          Components: dfs
>            Reporter: dhruba borthakur
>         Assigned To: dhruba borthakur
>         Attachments: renameToWindows.patch
>
>
> The new unit test that tests periodic checkpointing fails on Windows. The problem is that the method FSEditLog.purgeEditLog() uses renameTo() to atomically move edits.new to edits
> File.renameTo() fails on Windows is not atomic: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4017593
> I propose that we change this code to first try the renameTo(). If it fails, then it deletes edits and then renames edits.new to edits. 
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.