[GitHub] [poi] RemboL edited a comment on pull request #185: Fix if function in array formulas with 2nd argument evaluating to error

[GitBox <gi...@apache.org>]

RemboL edited a comment on pull request #185:
URL: https://github.com/apache/poi/pull/185#issuecomment-653321876


   Yes.
   
   This test is built so that it scans the excel file and adds new data row to `@Parameterized` test defined in the base class per properly defined row in excel. I've added 4 new rows to pre-existing xls (while leaving all the previous rows intact) that asserts behavior I'm interested in - so in fact I've added 4 new assertions to pre-existing `@Parameterized` test. 
   
   These assertions failed (specifically, the one that was testing this particular situation) until I've modified the if function itself - and after modifying the function, all the other tests were still green - so personally I'm satisfied with how this modification is tested.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org