[GitHub] [airflow] potiuk commented on pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on PR #28900:
URL: https://github.com/apache/airflow/pull/28900#issuecomment-1538786353

   It's good. The AIP-44 can proceed. I am just about to resume some of my PRs (I was busy with some security related stuff and helping with 2.6.0 teething problems) - but I am planning to start converting some of the job related calls. 
   
   The serialization is there, working - so serializing ORM objects should work out-of-the-box - producing the Pydantic version and the internal_api call implementation can proceed, no problems, I believe.
   
   We have the feature flag (`_ENABLE_AIP_44`) that should guard any changes that might cause problems when cherry-picking - but I think all the places where it needs to be applied (i.e serialization and CLI) it's already there, so the only place where it should be used if when we add tests that expect AIP_44 to be enabled (in `main`,  breeze and when you run tests in local venv  it should be enabled automatically). So we should basically add this to all tests that do some specific AIP-44 tests:
   
   ```
   @pytest.mark.skipif(not _ENABLE_AIP_44, reason="AIP-44 is disabled") 
   ```
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org