[GitHub] [incubator-superset] ebuildy commented on pull request #1866: Fix hardcoded urls in python and template files.

[GitBox <gi...@apache.org>]

ebuildy commented on pull request #1866:
URL: https://github.com/apache/incubator-superset/pull/1866#issuecomment-658663635


   @christophlingg this is just doing the job for the HTML page, all other stuff (static CSS, ...) is not using URL prefix and should never hit the right backend server (superset).
   
   Most entreprise users are using software behind proxy, for infrastructure / security / auth reasons. At X.com, we are running all analytics services behind ``/analytics/{service}`` URL, most softwares provide settings for that (https://grafana.com/tutorials/run-grafana-behind-a-proxy/#1), this PR look awesome, any plan to finish it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org