[GitHub] [pulsar] merlimat commented on a change in pull request #9308: Wait for broker port listeners to shutdown in BrokerService.close

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #9308:
URL: https://github.com/apache/pulsar/pull/9308#discussion_r565390915



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -120,13 +120,18 @@
         category = CATEGORY_SERVER,
         doc = "The port for serving binary protobuf requests"
     )
-
     private Optional<Integer> brokerServicePort = Optional.of(6650);
     @FieldContext(
         category = CATEGORY_SERVER,
         doc = "The port for serving tls secured binary protobuf requests"
     )
     private Optional<Integer> brokerServicePortTls = Optional.empty();
+    @FieldContext(
+            category = CATEGORY_SERVER,
+            doc = "The maximum duration (in seconds) to wait for each broker service network port to close "
+                    + "at broker service shutdown. No waiting will take place when the value is set to <= 0."
+    )
+    private int brokerServicePortCloseTimeoutInSeconds = 2;

Review comment:
       Since there are many executors that we're shutting down, we should just have 1 single configuration. It might even make sense to make it related to the setting: 
   
   ```
   # Time to wait for broker graceful shutdown. After this time elapses, the process will be killed
   brokerShutdownTimeoutMs=60000
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org