You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/11/11 23:26:08 UTC
Re: Review Request 26914: Right now at Mesos UI,
link are hardcoded to http:// . It should not be hardcoded so that it can
support https link. That is done.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26914/#review60873
-----------------------------------------------------------
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/26914/#comment102280>
you shouldn't need to add the http: prefix at all. just '//' + host + ... will default to whatever the current protocol is.
- Dominic Hamon
On Oct. 22, 2014, 6:48 a.m., Aditi Bhatnagar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26914/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 6:48 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1825
> https://issues.apache.org/jira/browse/MESOS-1825
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> https is also supported now, the static http case modified by appropriate if else clause.
>
>
> Diffs
> -----
>
> src/webui/master/static/js/controllers.js 41a70a8
>
> Diff: https://reviews.apache.org/r/26914/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditi Bhatnagar
>
>