You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by "tballison (via GitHub)" <gi...@apache.org> on 2023/06/21 15:59:04 UTC
[GitHub] [poi] tballison opened a new pull request, #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
tballison opened a new pull request, #477:
URL: https://github.com/apache/poi/pull/477
This is a first draft at making stream/directory name look up case insensitive for OLE2 containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1724228077
I _think_ I had already brought in your changes. I've since merged from
upstream and am getting the same two exceptions.
On Mon, Sep 18, 2023 at 2:26 PM Dominik Stadler ***@***.***>
wrote:
> Sorry, my bad, different version of Java have different XML Parsers,
> should be fixed on latest trunk, please rebase/merge onto latest.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/poi/pull/477#issuecomment-1724151675>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABTNNPXSZOGXHRGALNIQDLTX3CG6PANCNFSM6AAAAAAZO65RZM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Bug47950 -- make stream/directory name lookup in OLE2 case insensitive [poi]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1764144640
Committed: https://svn.apache.org/viewvc?view=revision&revision=1912438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1728347861
@tballison You need to commit this to svn. https://svn.apache.org/repos/asf/poi/trunk
The git repo is a read-only mirror afaik.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on a diff in pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #477:
URL: https://github.com/apache/poi/pull/477#discussion_r1237313858
##########
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java:
##########
@@ -297,11 +298,15 @@ public static String getWorkbookDirEntryName(DirectoryNode directory) {
"It must be decrypted before use by XSSF, it cannot be used by HSSF");
}
- // check for previous version of file format
- if (directory.hasEntry(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
+ // check case-sensitive for previous version of file format
+ if (directory.getEntryNames().contains(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
throw new OldExcelFormatException("The supplied spreadsheet seems to be Excel 5.0/7.0 (BIFF5) format. "
+ "POI only supports BIFF8 format (from Excel versions 97/2000/XP/2003)");
}
+ //check for non-case-senstive book (e.g. crystal) after ruling out case-sensitive OldExcelFormatException
Review Comment:
minor type - should be `sensitive`
##########
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java:
##########
@@ -297,11 +298,15 @@ public static String getWorkbookDirEntryName(DirectoryNode directory) {
"It must be decrypted before use by XSSF, it cannot be used by HSSF");
}
- // check for previous version of file format
- if (directory.hasEntry(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
+ // check case-sensitive for previous version of file format
+ if (directory.getEntryNames().contains(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
throw new OldExcelFormatException("The supplied spreadsheet seems to be Excel 5.0/7.0 (BIFF5) format. "
+ "POI only supports BIFF8 format (from Excel versions 97/2000/XP/2003)");
}
+ //check for non-case-senstive book (e.g. crystal) after ruling out case-sensitive OldExcelFormatException
Review Comment:
minor typo - should be `sensitive`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] centic9 commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "centic9 (via GitHub)" <gi...@apache.org>.
centic9 commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1724345432
As this file is now set to IGNORED in stress.xls it should not be executed at all, so if you see the same file-name "clusterfuzz-testcase-minimized-POIXWPFFuzzer-6733884933668864.docx" in the failures, the necessary change seems to be still missing.
CI-Jobs at https://ci-builds.apache.org/job/POI/ were failing as well and are now fixed, thus I am fairly confident that latest trunk has it fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603266141
Should I add `getEntryCaseInsensitive` and `hasEntryCaseInsensitive` to the `DirectoryEntry` interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on a diff in pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on code in PR #477:
URL: https://github.com/apache/poi/pull/477#discussion_r1237326799
##########
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java:
##########
@@ -297,11 +298,15 @@ public static String getWorkbookDirEntryName(DirectoryNode directory) {
"It must be decrypted before use by XSSF, it cannot be used by HSSF");
}
- // check for previous version of file format
- if (directory.hasEntry(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
Review Comment:
Y, I don't like the backwards compatibility break that this proposed change brings about. If we don't do this, though, then we'll have to change `hasEntry(name)` and `getEntry(name)` to the case insensitive options throughout our codebase. I can do that if desired.
Yep, I'll add that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603322580
PR just got huge...LOL...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1602800430
Results show no significant changes in 400k msoffice files (not all ole2): https://corpora.tika.apache.org/base/reports/tika-2.8.1-msoffice-reports.tgz
There is a major difference in handling "true"/"false" "1/0" in xlsx(?only?) between the versions of POI, but this change is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] centic9 commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "centic9 (via GitHub)" <gi...@apache.org>.
centic9 commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1724151675
Sorry, my bad, different version of Java have different XML Parsers, should be fixed on latest trunk, please rebase/merge onto latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603271152
Agree, but won't that break any implementations of DirectoryEntry? I can't imagine anyone is actually doing this, but, it still would break backward compatibility, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603277123
I still think we should add it to the interface. The number of affected users will be low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on a diff in pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #477:
URL: https://github.com/apache/poi/pull/477#discussion_r1237313415
##########
poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java:
##########
@@ -297,11 +298,15 @@ public static String getWorkbookDirEntryName(DirectoryNode directory) {
"It must be decrypted before use by XSSF, it cannot be used by HSSF");
}
- // check for previous version of file format
- if (directory.hasEntry(OLD_WORKBOOK_DIR_ENTRY_NAME)) {
Review Comment:
Not a big deal if this is too hard but is there any chance that `hasEntry` could remain case sensitive for backward compatibility reasons? And a new `caseInsensitiveHasEntry` added?
If leaving `hasEntry` case sensitive is too hard, could you could not using `directory.getEntryNames().contains` and adding a `caseSensitiveHasEntry` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1638639602
Sure - seems ok to me. You'll need to rebase your branch before submitting to svn because a few changes have gone into trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1715424815
Y, will update it today and merge. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603015916
@tballison could you raise an issue for the xssf boolean issue with and xlsx attached that makes it easier to debug?
With this PR, I'm still a little concerned about changing the behaviour of hasEntry/getEntry. I suppose that we could agree that the next release of POI has to be a v5.3.0 instead of v5.2.4 because of the behaviour change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1723696289
I'm consistently getting two test failures now locally:
```
[TestAllFiles](file:///home/tallison/Intellij/my-poi/poi-integration/build/reports/tests/test/classes/org.apache.poi.stress.TestAllFiles.html). [Extracting - #443 document/clusterfuzz-testcase-minimized-POIXWPFFuzzer-6733884933668864.docx XWPF](file:///home/tallison/Intellij/my-poi/poi-integration/build/reports/tests/test/classes/org.apache.poi.stress.TestAllFiles.html#handleExtracting(String,%20FileHandlerKnown,%20String,%20Class,%20String)[443])
[TestAllFiles](file:///home/tallison/Intellij/my-poi/poi-integration/build/reports/tests/test/classes/org.apache.poi.stress.TestAllFiles.html). [#443 document/clusterfuzz-testcase-minimized-POIXWPFFuzzer-6733884933668864.docx XWPF](file:///home/tallison/Intellij/my-poi/poi-integration/build/reports/tests/test/classes/org.apache.poi.stress.TestAllFiles.html#handleFile(String,%20FileHandlerKnown,%20String,%20Class,%20String)[443])
```
```
org.opentest4j.AssertionFailedError: document/clusterfuzz-testcase-minimized-POIXWPFFuzzer-6733884933668864.docx - failed for handler XWPFFileHandler: ==> Unexpected exception thrown: org.apache.xmlbeans.XmlException: error: Element or attribute "a:" do not match QName production: QName::=(NCName:)?NCName.
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
...
Caused by: org.apache.xmlbeans.XmlException: error: Element or attribute "a:" do not match QName production: QName::=(NCName:)?NCName.
...
Caused by: org.xml.sax.SAXParseException; systemId: file://; lineNumber: 2; columnNumber: 6188; Element or attribute "a:" do not match QName production: QName::=(NCName:)?NCName.
at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204)
at com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:178)
at com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:399)
at com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:326)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1728341260
Looks like I don't have write access?! @pjfanning or @centic9 would you be able to merge? THANK YOU!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1638611845
@pjfanning , wdyt? Ready to merge or further work required? Thanks, again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Bug47950 -- make stream/directory name lookup in OLE2 case insensitive [poi]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1763357507
@tballison could you close this? I believe that this was applied and was part of POI 5.2.4 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Bug47950 -- make stream/directory name lookup in OLE2 case insensitive [poi]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison closed pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
URL: https://github.com/apache/poi/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1728358103
[47950.zip](https://github.com/apache/poi/files/12677155/47950.zip)
This patch looks about right. Will apply shortly. Sorry about that, and thank you, again, @pjfanning and @centic9!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1715423133
@tballison is this PR still something that you want to merge? It's a year since the last POI release and it would be good to get a release out in the next month or 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1601257966
I look forward to running the regression tests after this change. :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603237387
I'm not sure the boolean issue is wrong, just different. When I opened a couple of the files, there was nothing in the cells. Will look deeper later.
I'm also concerned about changing the behavior. We could go to 5.3.0, or I could have a major refactoring where I modify all the internal `hasEntry` and `getEntry` to `hasEntryCaseInsensitive` and `getEntryCaseInsensitive`. If Intellij is accurate, there are ~230 uses of `getEntry` and ~90 `hasEntry`.
I'm willing to make that change, but it will be a large set of changes -- TBF, a bunch are in unit tests. Let me know what you think.
The other thing I shuoldn't have done was change the values of `InternalWorkbook#WORKBOOK_DIR_ENTRY_NAMES`. I should have left that as is and mad my own mods on a new field. I'll change that back to what it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603268502
> Should I add `getEntryCaseInsensitive` and `hasEntryCaseInsensitive` to the `DirectoryEntry` interface?
Seems best to expose them fully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1603244993
If possible and the IDE makes it easy, I think keeping getEntry/hasEntry case-sensitive and switching most code to a set of case-sensitive methods makes releasing easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1728349147
:facepalm:
On Wed, Sep 20, 2023 at 4:00 PM PJ Fanning ***@***.***> wrote:
> @tballison <https://github.com/tballison> You need to commit this to svn.
> https://svn.apache.org/repos/asf/poi/trunk
>
> The git repo is a read-only mirror afaik.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/poi/pull/477#issuecomment-1728347861>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABTNNPWPIU2BR325IY7TBALX3NDNNANCNFSM6AAAAAAZO65RZM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1728295876
Pushed merge remote-tracking. I'm getting a clean build now. Thank you @centic9 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] tballison commented on pull request #477: Bug47950 -- make stream/directory name lookup in OLE2 case insensitive
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #477:
URL: https://github.com/apache/poi/pull/477#issuecomment-1721831816
Argh... Monday...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org