You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/08/01 18:23:01 UTC
Review Request 24185: CLOUDSTACK-7224: Fixed marvin code for async jobs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24185/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-7224
https://issues.apache.org/jira/browse/CLOUDSTACK-7224
Repository: cloudstack-git
Description
-------
ResponseType is not passed from asyncJobMgr to marvinRequest function, only command is passed. In this case responseType parameter should not be set as mandatory in marvinReqest. Make it optional.
Also remove connection.close() , as there is no close method for cloudstackConnection. Closing the connection is not required as the copy of cloudstackConnection which is created for every worker thread will be deleted once it goes out of scope.
Diffs
-----
tools/marvin/marvin/asyncJobMgr.py 00e8c19
tools/marvin/marvin/cloudstackConnection.py a8c35f6
Diff: https://reviews.apache.org/r/24185/diff/
Testing
-------
Test perform concurrent snapshots and migrate the vm from one host ... === TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS ===
ok
Test stop running VM while performing concurrent snapshot on volume ... SKIP: skip
Test while parent concurrent snapshot job in progress,create ... SKIP: skip
Test while parent concurrent snapshot job in progress,create volume ... SKIP: skip
----------------------------------------------------------------------
Ran 4 tests in 201.910s
OK (SKIP=3)
Thanks,
Gaurav Aradhye
Re: Review Request 24185: CLOUDSTACK-7224: Fixed marvin code for async jobs
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24185/#review49353
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 1, 2014, 4:23 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24185/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 4:23 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7224
> https://issues.apache.org/jira/browse/CLOUDSTACK-7224
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> ResponseType is not passed from asyncJobMgr to marvinRequest function, only command is passed. In this case responseType parameter should not be set as mandatory in marvinReqest. Make it optional.
>
> Also remove connection.close() , as there is no close method for cloudstackConnection. Closing the connection is not required as the copy of cloudstackConnection which is created for every worker thread will be deleted once it goes out of scope.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/asyncJobMgr.py 00e8c19
> tools/marvin/marvin/cloudstackConnection.py a8c35f6
>
> Diff: https://reviews.apache.org/r/24185/diff/
>
>
> Testing
> -------
>
> Test perform concurrent snapshots and migrate the vm from one host ... === TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS ===
> ok
> Test stop running VM while performing concurrent snapshot on volume ... SKIP: skip
> Test while parent concurrent snapshot job in progress,create ... SKIP: skip
> Test while parent concurrent snapshot job in progress,create volume ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 4 tests in 201.910s
>
> OK (SKIP=3)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24185: CLOUDSTACK-7224: Fixed marvin code for async jobs
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24185/#review49354
-----------------------------------------------------------
Commit 93c64cd7f210f4a666611b1e8b71f8cf7edcc8eb in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=93c64cd ]
CLOUDSTACK-7224: Fixed marvin code for async jobs
Signed-off-by: Santhosh Edukulla <sa...@gmail.com>
- ASF Subversion and Git Services
On Aug. 1, 2014, 4:23 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24185/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 4:23 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7224
> https://issues.apache.org/jira/browse/CLOUDSTACK-7224
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> ResponseType is not passed from asyncJobMgr to marvinRequest function, only command is passed. In this case responseType parameter should not be set as mandatory in marvinReqest. Make it optional.
>
> Also remove connection.close() , as there is no close method for cloudstackConnection. Closing the connection is not required as the copy of cloudstackConnection which is created for every worker thread will be deleted once it goes out of scope.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/asyncJobMgr.py 00e8c19
> tools/marvin/marvin/cloudstackConnection.py a8c35f6
>
> Diff: https://reviews.apache.org/r/24185/diff/
>
>
> Testing
> -------
>
> Test perform concurrent snapshots and migrate the vm from one host ... === TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS ===
> ok
> Test stop running VM while performing concurrent snapshot on volume ... SKIP: skip
> Test while parent concurrent snapshot job in progress,create ... SKIP: skip
> Test while parent concurrent snapshot job in progress,create volume ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 4 tests in 201.910s
>
> OK (SKIP=3)
>
>
> Thanks,
>
> Gaurav Aradhye
>
>