[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5823: [TE] enchance anomaly api to propagate feedback

[GitBox <gi...@apache.org>]

jihaozh commented on a change in pull request #5823:
URL: https://github.com/apache/incubator-pinot/pull/5823#discussion_r466705333



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java
##########
@@ -456,6 +456,24 @@ public void updateAnomalyFeedback(MergedAnomalyResultDTO entity) {
     return this.getAnomaliesForMetricBeanAndTimeRange(mbean, start, end);
   }
 
+  @Override
+  public MergedAnomalyResultDTO findParent(MergedAnomalyResultDTO entity) {
+    List<MergedAnomalyResultBean> candidates = genericPojoDao.get(Predicate.AND(
+        Predicate.EQ("detectionConfigId", entity.getDetectionConfigId()),
+        Predicate.LE("startTime", entity.getStartTime()),

Review comment:
       we may need to consider the potential merging gap between the parent and children anomaly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org