You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2016/04/20 12:25:24 UTC
[GitHub] nifi pull request: NIFI-1788 Fixed listed allowable values
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/368
NIFI-1788 Fixed listed allowable values
- fixed list of allowable values
- replaced related deprecated method when writing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-1788
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/368.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #368
----
commit 08f7dc8991c05c26115557f1c625ca27fe1d7112
Author: Pierre Villard <pi...@gmail.com>
Date: 2016-04-20T10:24:39Z
NIFI-1788 Fixed listed allowable values
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1788 Fixed listed allowable values
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/368
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1788 Fixed listed allowable values
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/368#issuecomment-212427393
@pvillard31 I know we have a lot of these "quick-fix-hit-and-run" bugs that require half a line of code change (and you've been absolutely awesome in knocking those out along with more complex JIRAs), but try to always remember that we wouldn't be here if test(s) for these things existed in the first place. So, while fixing such issue I personally strongly encourage to add/modify/create test case as part of the fix.
Feel free to use this:
```java
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.nifi.processors.hadoop;
import static org.junit.Assert.assertEquals;
import java.util.List;
import org.apache.nifi.components.AllowableValue;
import org.apache.nifi.components.PropertyDescriptor;
import org.junit.Test;
public class CreateHadoopSequenceFileTest {
@Test
public void validateAllowableValues() {
PropertyDescriptor pd = CreateHadoopSequenceFile.COMPRESSION_TYPE;
List<AllowableValue> allowableValues = pd.getAllowableValues();
assertEquals("NONE", allowableValues.get(0).getValue());
assertEquals("RECORD", allowableValues.get(1).getValue());
assertEquals("BLOCK", allowableValues.get(2).getValue());
}
}
```
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1788 Fixed listed allowable values
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/368#discussion_r60416327
--- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/SequenceFileWriterImpl.java ---
@@ -94,8 +94,10 @@ public void process(InputStream in, OutputStream out) throws IOException {
try (final FSDataOutputStream fsDataOutputStream = new FSDataOutputStream(bwos, new Statistics(""));
final SequenceFile.Writer writer = SequenceFile.createWriter(configuration,
- fsDataOutputStream, Text.class, InputStreamWritable.class, compressionType,
- new DefaultCodec())) {
+ SequenceFile.Writer.stream(fsDataOutputStream),
+ SequenceFile.Writer.keyClass(Text.class),
+ SequenceFile.Writer.valueClass(InputStreamWritable.class),
+ SequenceFile.Writer.compression(compressionType, new DefaultCodec()))) {
--- End diff --
@olegz OK, thanks, I'll raise a JIRA shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1788 Fixed listed allowable values
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/368#issuecomment-212445861
@olegz You are absolutely right! Thanks for the lines of code, added the test in an existing test class for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1788 Fixed listed allowable values
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/368#discussion_r60384217
--- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/SequenceFileWriterImpl.java ---
@@ -94,8 +94,10 @@ public void process(InputStream in, OutputStream out) throws IOException {
try (final FSDataOutputStream fsDataOutputStream = new FSDataOutputStream(bwos, new Statistics(""));
final SequenceFile.Writer writer = SequenceFile.createWriter(configuration,
- fsDataOutputStream, Text.class, InputStreamWritable.class, compressionType,
- new DefaultCodec())) {
+ SequenceFile.Writer.stream(fsDataOutputStream),
+ SequenceFile.Writer.keyClass(Text.class),
+ SequenceFile.Writer.valueClass(InputStreamWritable.class),
+ SequenceFile.Writer.compression(compressionType, new DefaultCodec()))) {
--- End diff --
Is it expected to use DefaultCodec? I saw we have a property for compression codec, shouldn't we propose something to use this property at this moment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1788 Fixed listed allowable values
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/368#discussion_r60407160
--- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/SequenceFileWriterImpl.java ---
@@ -94,8 +94,10 @@ public void process(InputStream in, OutputStream out) throws IOException {
try (final FSDataOutputStream fsDataOutputStream = new FSDataOutputStream(bwos, new Statistics(""));
final SequenceFile.Writer writer = SequenceFile.createWriter(configuration,
- fsDataOutputStream, Text.class, InputStreamWritable.class, compressionType,
- new DefaultCodec())) {
+ SequenceFile.Writer.stream(fsDataOutputStream),
+ SequenceFile.Writer.keyClass(Text.class),
+ SequenceFile.Writer.valueClass(InputStreamWritable.class),
+ SequenceFile.Writer.compression(compressionType, new DefaultCodec()))) {
--- End diff --
@pvillard31 I would agree. In any event raising an improvement JIRA will let such discussion to begin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---