You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by "zhongjiajie (via GitHub)" <gi...@apache.org> on 2023/02/15 06:44:44 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #12969: [Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.DataAnalysisController

zhongjiajie commented on PR #12969:
URL: https://github.com/apache/dolphinscheduler/pull/12969#issuecomment-1430838904

   > Result should be encapsulated in Collonter layer, not service layer
   
   I agree with Calvin, we should avoid returning simple object instead of results in service, especially since your patch is refactoring for our codebase, we should try to make it better


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org