[jira] Updated: (DERBY-1660) SYSCS_BULK_INSERT fails with syntax error at PROPERTIES clause.

["Sunitha Kambhampati (JIRA)" <de...@db.apache.org>]

     [ http://issues.apache.org/jira/browse/DERBY-1660?page=all ]

Sunitha Kambhampati updated DERBY-1660:
---------------------------------------

    Attachment: bulkinsert.diff.txt

I am attaching the patch bulkinsert.diff.txt to fix this issue.

This patch 
-- fixes the sql query used in the SYSCS_BULK_INSERT procedure to correctly use the   optimizer hints using  --DERBY-PROPERTIES clause instead of PROPERTIES. 

I have run an inhouse test that uses bulkinsert and vti to populate data and the test ran fine.  I plan to look into adding a regression test for this, I'll upload that as a separate patch.

I ran derbyall on windows/jdk142 ok.

svn stat
M      java\engine\org\apache\derby\catalog\SystemProcedures.java

Can some please review this.    Thanks.

> SYSCS_BULK_INSERT fails with syntax error at PROPERTIES clause.
> ---------------------------------------------------------------
>
>                 Key: DERBY-1660
>                 URL: http://issues.apache.org/jira/browse/DERBY-1660
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.2.0.0
>            Reporter: Sunitha Kambhampati
>         Assigned To: Sunitha Kambhampati
>            Priority: Minor
>             Fix For: 10.2.0.0
>
>         Attachments: bulkinsert.diff.txt
>
>
> Calling procedure SYSCS_BULK_INSERT  fails in 10.2 , throwing a syntax error when it sees the PROPERTIES clause.
> SystemProcedures.SYSCS_BULK_INSERT uses the following sql query.
>        String binsertSql =
>            "insert into " + entityName +
>            " PROPERTIES insertMode=bulkInsert " +
>            "select * from new " + vtiName +
>            "(" +
>            "'" + schemaName + "'" + ", " +
>            "'" + tableName + "'" +  ", " +
>            "'" + vtiArg + "'" +  ")" +
>            " as t";
> I think because of the optimizer overrides in 10.2, this query does not work. 
> Instead of the PROPERTIES clause, we should now use --DERBY-PROPERTIES.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira