You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2023/04/05 09:40:07 UTC

[camel] branch main updated: Removed empty List of RouteBuilders and the related loop. This loop does nothing. (#9815)

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new e50f09d3249 Removed empty List of RouteBuilders and the related loop. This loop does nothing. (#9815)
e50f09d3249 is described below

commit e50f09d3249bf9f77a0476d475ace4037a35e9d5
Author: dk2k <dk...@users.noreply.github.com>
AuthorDate: Wed Apr 5 12:39:59 2023 +0300

    Removed empty List of RouteBuilders and the related loop. This loop does nothing. (#9815)
    
    Co-authored-by: dk2k <dk...@ya.ru>
---
 .../apache/camel/core/xml/AbstractCamelContextFactoryBean.java   | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/core/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java b/core/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java
index 35ea6341b13..a146e23ed3d 100644
--- a/core/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java
+++ b/core/camel-core-xml/src/main/java/org/apache/camel/core/xml/AbstractCamelContextFactoryBean.java
@@ -1363,9 +1363,8 @@ public abstract class AbstractCamelContextFactoryBean<T extends ModelCamelContex
      * Strategy to install all available routes into the context
      */
     protected void installRoutes() throws Exception {
-        List<RouteBuilder> builders = new ArrayList<>();
 
-        // lets add RoutesBuilder's added from references
+        // let's add RoutesBuilder's added from references
         if (getBuilderRefs() != null) {
             for (RouteBuilderDefinition builderRef : getBuilderRefs()) {
                 RoutesBuilder routes = builderRef.createRoutes(getContext());
@@ -1382,12 +1381,6 @@ public abstract class AbstractCamelContextFactoryBean<T extends ModelCamelContex
             getContext().addRoutes(routeBuilder);
         }
 
-        // install builders
-        for (RouteBuilder builder : builders) {
-            // Inject the annotated resource
-            postProcessBeforeInit(builder);
-            getContext().addRoutes(builder);
-        }
     }
 
     protected abstract void postProcessBeforeInit(RouteBuilder builder);