You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/28 09:44:38 UTC
[GitHub] [flink] lirui-apache commented on a change in pull request #13216: [FLINK-18999][table-planner-blink][hive] Temporary generic table does…
lirui-apache commented on a change in pull request #13216:
URL: https://github.com/apache/flink/pull/13216#discussion_r495815935
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -109,11 +109,27 @@ public static DynamicTableSource createTableSource(
CatalogTable catalogTable,
ReadableConfig configuration,
ClassLoader classLoader) {
+ return createTableSource(catalog, objectIdentifier, catalogTable, configuration, classLoader, false);
+ }
+
+ /**
+ * Creates a {@link DynamicTableSource} from a {@link CatalogTable}.
+ *
+ * <p>It considers {@link Catalog#getFactory()} if provided.
+ */
+ public static DynamicTableSource createTableSource(
Review comment:
Some tests rely on the old method. But I agree it's better to remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org