You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2023/08/29 03:45:12 UTC

[GitHub] [incubator-celeborn] SteNicholas commented on a diff in pull request #1814: [CELEBORN-830] Check available workers in CelebornShuffleFallbackPolicyRunner

SteNicholas commented on code in PR #1814:
URL: https://github.com/apache/incubator-celeborn/pull/1814#discussion_r1308161112


##########
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala:
##########
@@ -343,6 +343,10 @@ object ControlMessages extends Logging {
 
   case class CheckQuotaResponse(isAvailable: Boolean, reason: String) extends Message
 
+  case class CheckWorkersAvailable() extends Message

Review Comment:
   @waitinfuture, @pan3793, I have followed the pattern of `RegisterWorker` and `RegisterWorkerResponse`. PTAL. BTW, could the standard that uses raw Pb messages instead of defining case class document in contribution page?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org