You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/03/10 22:46:05 UTC

[GitHub] [hudi] alexeykudinkin commented on pull request #4264: [HUDI-2875] Make HoodieParquetWriter Thread safe and memory executor …

alexeykudinkin commented on pull request #4264:
URL: https://github.com/apache/hudi/pull/4264#issuecomment-1064583802


   @guanziyue thank you for taking the time to troubleshoot this concurrency issues and implement the fix!
   
   I echo @vinothchandar concerns and i think we're taking a step a bit too far -- `ParquetWriter` is not assumed to be thread-safe, neither do i believe we should make it such. 
   Instead, i believe we should just resolve the problem with its concurrent access (which you already did) and make sure we make it clear that `ParquetWriter` is not thread-safe so its usage need to be properly guarded externally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org