You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues-all@impala.apache.org by "Lars Volker (JIRA)" <ji...@apache.org> on 2018/09/04 16:36:00 UTC

[jira] [Created] (IMPALA-7524) Keep frame pointers for generated code

Lars Volker created IMPALA-7524:
-----------------------------------

             Summary: Keep frame pointers for generated code
                 Key: IMPALA-7524
                 URL: https://issues.apache.org/jira/browse/IMPALA-7524
             Project: IMPALA
          Issue Type: Improvement
          Components: Backend
    Affects Versions: Impala 2.13.0, Impala 3.1.0
            Reporter: Lars Volker


Generated code does not preserve the frame pointer and thus stack unwinding does not work when we crash in generated functions. We should preserve the frame pointers to make debugging easier. Kudu's experience and our own in IMPALA-4132 suggest that the performance hit will be tolerable (but we still should do a proper perf evaluation).

Here's Kudu's way of preserving the frame pointers: [module_builder.cc:294|https://github.com/apache/kudu/blob/eb15beabd2d4d86649a35dcd027e1749cc695866/src/kudu/codegen/module_builder.cc#L294].

Thanks [~tlipcon] for the suggestion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org