You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sumitagrawl (via GitHub)" <gi...@apache.org> on 2025/10/27 09:27:01 UTC
[PR] HDDS-13842. revert disable ratis metadata write for SC [ozone]
sumitagrawl opened a new pull request, #9202:
URL: https://github.com/apache/ozone/pull/9202
## What changes were proposed in this pull request?
Revert only **disable ratis metadata write for SCM** as changes done by
[HDDS-13281. Disable Ratis metadata write to Raft Log on OM & SCM](https://github.com/apache/ozone/pull/8637)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13842
## How was this patch tested?
- CI test cases for impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Exit safemode rule quickly at follower for idle SCM [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl closed pull request #9202: HDDS-13842. Exit safemode rule quickly at follower for idle SCM
URL: https://github.com/apache/ozone/pull/9202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Revert disable Ratis metadata write for SCM [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #9202:
URL: https://github.com/apache/ozone/pull/9202#discussion_r2470047735
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -167,9 +167,7 @@ public CompletableFuture<Message> applyTransaction(
if (scm.isInSafeMode() && refreshedAfterLeaderReady.get()) {
scm.getScmSafeModeManager().refreshAndValidate();
}
- final TermIndex appliedTermIndex = TermIndex.valueOf(trx.getLogEntry());
- transactionBuffer.updateLatestTrxInfo(TransactionInfo.valueOf(appliedTermIndex));
- updateLastAppliedTermIndex(appliedTermIndex);
Review Comment:
@sumitagrawl , This bug was discovered when trying to disable metadata. I agree that it is better to update the description but people usually do not do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Revert disable Ratis metadata write for SCM [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on PR #9202:
URL: https://github.com/apache/ozone/pull/9202#issuecomment-3471767971
This revert has not fixed the issue, closing the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. revert disable ratis metadata write for SC [ozone]
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #9202:
URL: https://github.com/apache/ozone/pull/9202#issuecomment-3450983717
Could you please check this @octachoron? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Exit safemode rule quickly at follower for idle SCM [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl merged PR #9202:
URL: https://github.com/apache/ozone/pull/9202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. revert disable ratis metadata write for SC [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #9202:
URL: https://github.com/apache/ozone/pull/9202#discussion_r2466445254
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -167,9 +167,7 @@ public CompletableFuture<Message> applyTransaction(
if (scm.isInSafeMode() && refreshedAfterLeaderReady.get()) {
scm.getScmSafeModeManager().refreshAndValidate();
}
- final TermIndex appliedTermIndex = TermIndex.valueOf(trx.getLogEntry());
- transactionBuffer.updateLatestTrxInfo(TransactionInfo.valueOf(appliedTermIndex));
- updateLastAppliedTermIndex(appliedTermIndex);
Review Comment:
It is correct to call `updateLastAppliedTermIndex(..)` after applied a transaction. This was a bug fixed by HDDS-13281. We should not revert this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Revert disable Ratis metadata write for SCM [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on code in PR #9202:
URL: https://github.com/apache/ozone/pull/9202#discussion_r2468005623
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -167,9 +167,7 @@ public CompletableFuture<Message> applyTransaction(
if (scm.isInSafeMode() && refreshedAfterLeaderReady.get()) {
scm.getScmSafeModeManager().refreshAndValidate();
}
- final TermIndex appliedTermIndex = TermIndex.valueOf(trx.getLogEntry());
- transactionBuffer.updateLatestTrxInfo(TransactionInfo.valueOf(appliedTermIndex));
- updateLastAppliedTermIndex(appliedTermIndex);
Review Comment:
@szetszwo
ok, will add, this was never mentioned in change description in HDDS-13281 as fixing additional bug. We should capture this also in bug description to avoid confusion` if fixing additional bug with same JIRA`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Exit safemode rule quickly at follower for idle SCM [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on PR #9202:
URL: https://github.com/apache/ozone/pull/9202#issuecomment-3566644537
@szetszwo Updated the PR revert back to original state and remaining changes will be done as separate PR, please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Revert disable Ratis metadata write for SCM [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl commented on code in PR #9202:
URL: https://github.com/apache/ozone/pull/9202#discussion_r2468005623
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -167,9 +167,7 @@ public CompletableFuture<Message> applyTransaction(
if (scm.isInSafeMode() && refreshedAfterLeaderReady.get()) {
scm.getScmSafeModeManager().refreshAndValidate();
}
- final TermIndex appliedTermIndex = TermIndex.valueOf(trx.getLogEntry());
- transactionBuffer.updateLatestTrxInfo(TransactionInfo.valueOf(appliedTermIndex));
- updateLastAppliedTermIndex(appliedTermIndex);
Review Comment:
@szetszwo
ok, will add, this was never mentioned in change description in HDDS-13281 as fixing additional bug. We should capture this also in bug description to avoid confusion` if fixing additional bug with same JIRA`.
Updated the description in HDDS-13281 to include this infomation also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13842. Revert disable Ratis metadata write for SCM [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl closed pull request #9202: HDDS-13842. Revert disable Ratis metadata write for SCM
URL: https://github.com/apache/ozone/pull/9202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org