[ https://issues.apache.org/jira/browse/FLINK-7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172975#comment-16172975 ]
ASF GitHub Bot commented on FLINK-7651:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4686
[FLINK-7651] [flip-6] Delay RetryingRegistration in case of connection error
## What is the purpose of the change
Similar to a registration error we should also delay the retrying registration in case of
connection error which could happen if the remote endpoint has not been started yet.
## Brief change log
- delay `RetryingRegistration` in case of connection error.
## Verifying this change
This change is already covered by existing tests, such as `RetryingRegistrationTest#testRetryConnectOnFailure`. I simply added a time measurement which is used to check that the retrying is delayed.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink addRetryingRegistrationDelay
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4686.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4686
----
commit e63daa5f35b7ed064fc952ddf8d322f8f06493c1
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-09-20T10:04:58Z
[FLINK-7651] [flip-6] Delay RetryingRegistration in case of connection error
Similar to a registration error we should also delay the retrying registration in case of
connection error which could happen if the remote endpoint has not been started yet.
----
> RetryingRegistration does not wait between failed connection attempts
> ---------------------------------------------------------------------
>
> Key: FLINK-7651
> URL: https://issues.apache.org/jira/browse/FLINK-7651
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> The {{RetryingRegistration}} does not wait between connection attempts if a connection could not be established to the remote peer. This leads effectively to a busy retry loop. Similar to exceptions which occur at registration time, we should delay the retrying also in case of a connection error.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)