[jira] Commented: (DERBY-3988) Set the Java 6 complilation path based on the Java 5 compilation path so that the JDBC4 support is always built

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656295#action_12656295 ] 

Knut Anders Hatlen commented on DERBY-3988:
-------------------------------------------

I think removing the jdk16 variable and using the same compiler for all the classes is a good move, as it makes it easier to understand the build and which compiler has been used for which classes. But as I said in DERBY-3966, I'm not sure if compiling all classes with JDK 5 is what we want. The issues I see are:

  1) We're restricted to using a subset of Java SE 6 in code that is only ever used on Java SE 6

  2) We must compile the classes with target=1.5 instead of target=1.6, so we don't get the benefits of the new class format, like faster class loading

Is there any reason why we couldn't just take the full step and require JDK 6 instead of JDK 5? It's been two years since Java SE 6 was released, so I don't think it's unreasonable to expect that any serious Java development environment contains a Java 6 compiler these days.

Some possible improvements to the patch:

  - the compile_jdbc4 targets don't need fork="yes" anymore, I think

  - instead of always setting target=1.5 we could have a property that had the value 1.5 or 1.6 depending of the actual compiler used

  - instead of making jdbc4_modules_edit in java/engine/build.xml non-optional, we should remove that target and make the necessary changes to modules.properties

> Set the Java 6 complilation path based on the Java 5 compilation path so that the JDBC4 support is always built
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3988
>                 URL: https://issues.apache.org/jira/browse/DERBY-3988
>             Project: Derby
>          Issue Type: Improvement
>          Components: Build tools
>    Affects Versions: 10.5.0.0
>            Reporter: Rick Hillegas
>            Assignee: Rick Hillegas
>         Attachments: derby-3988-01-aa-alwaysCompileJDBC4.diff
>
>
> Now that we have checked in the JDBC4 stubs, it ought to be possible to build the JDBC4 support with just the Java 5 libraries and compiler. Set java16compile.classpath=${jdbc4stubs}:${java15compile.classpath}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [jira] Commented: (DERBY-3988) Set the Java 6 complilation path based on the Java 5 compilation path so that the JDBC4 support is always built

[Bryan Pendleton <bp...@amberpoint.com>]

> Is there any reason why we couldn't just take the full step and require JDK 6 instead of JDK 5?

To be clear, you propose to require JDK 6 for *building* Derby, but
the code, once built, would continue to run in the current set of
environments (JDK 1.4+, small environment, etc.)?

If so, that approach seems fine to me.

thanks,

bryan