You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/06 01:28:23 UTC

Re: Review Request 18550: Introduced CHECK_* for Future and use of ABORT_MSG

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18550/
-----------------------------------------------------------

(Updated March 5, 2014, 4:28 p.m.)


Review request for mesos and Benjamin Hindman.


Summary (updated)
-----------------

Introduced CHECK_* for Future and use of ABORT_MSG


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am a7d199f6b90fee0927ac33351939ddaf2e5a2f6a 
  3rdparty/libprocess/include/process/check.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/collect.hpp 2a73bc946fc4fa65229e9c979d841f2657a7cd2d 
  3rdparty/libprocess/include/process/future.hpp e45f4f79faeefbffc28d855d2f74e8df69099f18 
  3rdparty/libprocess/include/process/subprocess.hpp 452eeeae0a9f2353db2d9302be594a578db52026 

Diff: https://reviews.apache.org/r/18550/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18550: Introduced CHECK_* for Future and use of ABORT_MSG

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18550/#review36314
-----------------------------------------------------------

Ship it!


I'm going to commit this now!

- Benjamin Hindman


On March 6, 2014, 1 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18550/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 1 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1041
>     https://issues.apache.org/jira/browse/MESOS-1041
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am a7d199f6b90fee0927ac33351939ddaf2e5a2f6a 
>   3rdparty/libprocess/include/process/check.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/collect.hpp 2a73bc946fc4fa65229e9c979d841f2657a7cd2d 
>   3rdparty/libprocess/include/process/future.hpp e45f4f79faeefbffc28d855d2f74e8df69099f18 
>   3rdparty/libprocess/include/process/subprocess.hpp 452eeeae0a9f2353db2d9302be594a578db52026 
> 
> Diff: https://reviews.apache.org/r/18550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18550: Introduced CHECK_* for Future and use of ABORT_MSG

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18550/
-----------------------------------------------------------

(Updated March 5, 2014, 5 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs
-----

  3rdparty/libprocess/Makefile.am a7d199f6b90fee0927ac33351939ddaf2e5a2f6a 
  3rdparty/libprocess/include/process/check.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/collect.hpp 2a73bc946fc4fa65229e9c979d841f2657a7cd2d 
  3rdparty/libprocess/include/process/future.hpp e45f4f79faeefbffc28d855d2f74e8df69099f18 
  3rdparty/libprocess/include/process/subprocess.hpp 452eeeae0a9f2353db2d9302be594a578db52026 

Diff: https://reviews.apache.org/r/18550/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18550: Introduced CHECK_* for Future and use of ABORT_MSG

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18550/
-----------------------------------------------------------

(Updated March 5, 2014, 5 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/Makefile.am a7d199f6b90fee0927ac33351939ddaf2e5a2f6a 
  3rdparty/libprocess/include/process/check.hpp PRE-CREATION 
  3rdparty/libprocess/include/process/collect.hpp 2a73bc946fc4fa65229e9c979d841f2657a7cd2d 
  3rdparty/libprocess/include/process/future.hpp e45f4f79faeefbffc28d855d2f74e8df69099f18 
  3rdparty/libprocess/include/process/subprocess.hpp 452eeeae0a9f2353db2d9302be594a578db52026 

Diff: https://reviews.apache.org/r/18550/diff/


Testing
-------

make check


Thanks,

Dominic Hamon