You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2023/06/07 09:47:58 UTC
[GitHub] [calcite] gianm commented on pull request #3249: [CALCITE-5477] Build with Guava 19.0.
gianm commented on PR #3249:
URL: https://github.com/apache/calcite/pull/3249#issuecomment-1580328092
Note: this PR removes the `errorprone` action, leaving only `errorprone-guava31`. Rationale:
- Running errorprone on guava 19 is problematic, since it flags APIs that are `@Beta` in 19 but have stabilized by 31. It's OK to use these APIs, even on 19, because they're future-proof by virtue of the `@Beta` tag being removed in a later version.
- I don't see a reason to run errorprone on guava 19 at all, given that we are running it on guava 31. Before this patch, both the `errorprone` and `errorprone-guava31` actions ran on guava 31 anyway, because the default version to build was 31.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org