You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2023/06/12 15:32:47 UTC

[GitHub] [superset] sfirke opened a new issue, #24361: Horizontal dashboard filter bar should use full width available

sfirke opened a new issue, #24361:
URL: https://github.com/apache/superset/issues/24361

   With a dashboard filter bar in horizontal orientation and a single filter, it is truncated unnecessarily.
   
   #### How to reproduce the bug
   
   Create a dashboard, add a single time range filter, switch filter orientation to horizontal.  Or view this public example (URL subject to change): https://analytics.a2gov.org/superset/dashboard/rain-gauges-basic
   
   ### Expected results
   
   Filter uses available horizontal screen space, saying "Time Range."
   
   ### Actual results
   
   Filter is truncated, saying "Time Ra..."
   
   #### Screenshots
   ![image](https://github.com/apache/superset/assets/7569808/2dd6863a-14c2-4806-af94-3063546975de)
   
   I'd like to see the filter expand right into the highlighted whitespace.
   
   ### Environment
   
   Superset 2.1.0, HORIZONTAL_FILTER_BAR flag enabled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke commented on issue #24361: Horizontal dashboard filter bar should use full width available

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-1598596651

   Great, thanks for taking a shot at it! 🙏
   
   On Mon, Jun 19, 2023, 3:10 PM AshutoshNanaware ***@***.***>
   wrote:
   
   > Hi @sfirke <https://github.com/sfirke> , I have gone through the issue.
   > We want to utilize the extra blank space to show 'Time Range ' tab without
   > the dots. I am working on it.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/superset/issues/24361#issuecomment-1597636321>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ABZYDEBZ2LU6ZPI6NHC3TMDXMCP23ANCNFSM6AAAAAAZDR3W5I>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] AshutoshNanaware commented on issue #24361: Horizontal dashboard filter bar should use full width available

Posted by "AshutoshNanaware (via GitHub)" <gi...@apache.org>.
AshutoshNanaware commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-1597636321

   Hi @sfirke , I have gone through the issue. We want to utilize the extra blank space to show 'Time Range ' tab without the dots. I am working on it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Horizontal dashboard filter bar should use full width available [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-2043545903

   Indeed I just tested and this has been fixed as of 3.1.1! 🙌 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Horizontal dashboard filter bar should use full width available [superset]

Posted by "zuriscript (via GitHub)" <gi...@apache.org>.
zuriscript commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-1816667348

   As a temporary workaround, I've made good results with following css template:
   ```css
   .filter-item-wrapper h4 {
       max-width: max-content !important;
   }
   ```
   
   Keep in mind that this can break any time as soon as the dom structure changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Horizontal dashboard filter bar should use full width available [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-2043453395

   @sfirke this one's gone quiet for quite a while... do you think we still need it open?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Horizontal dashboard filter bar should use full width available [superset]

Posted by "israel-kochava (via GitHub)" <gi...@apache.org>.
israel-kochava commented on issue #24361:
URL: https://github.com/apache/superset/issues/24361#issuecomment-1756200010

   @AshutoshNanaware, have you made any progress on a fix for this?  I'd assume with a fix I won't have the truncation issues I do now as well... I was going to look into this with CSS but if you have something coming I'll wait.  Thanks 🍻 
   
   ![image](https://github.com/apache/superset/assets/15988284/53d22c3f-0bc7-4d5c-b8c9-b6fdfbfe0f01)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Horizontal dashboard filter bar should use full width available [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke closed issue #24361: Horizontal dashboard filter bar should use full width available
URL: https://github.com/apache/superset/issues/24361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org