anyone to review/commit the ix in ApplicationComposers?

[Romain Manni-Bucau <rm...@gmail.com>]

hi

in ApplicationComposers we were shuting down scopes (cdi ones) before the
app so the app scopes was off when BeforeShutdown was called

this is wrong and can be fixed
patching org.apache.openejb.testing.ApplicationComposers#after this way:
https://gist.github.com/rmannibucau/5396703

anyone could review and commit it for me referring the jira
https://issues.apache.org/jira/browse/OPENEJB-2014 ?

i'm currently totally out of sync because of OWB 1.2.0 work

*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*

Re: anyone to review/commit the ix in ApplicationComposers?

[AndyG <an...@orprovision.com>]

OK, will commit something later.



--
View this message in context: http://openejb.979440.n4.nabble.com/anyone-to-review-commit-the-ix-in-ApplicationComposers-tp4662301p4662319.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: anyone to review/commit the ix in ApplicationComposers?

[Romain Manni-Bucau <rm...@gmail.com>]

not sure we have a test for it,

basically using a @PreDestroy in an @ApplicationScoped bean which set a
static attribute (boolean) would be enough to check it works or not (ie is
the predestroy method called). Since the issue was we were stopping context
too early the method wouldn't be called if it is still broken

*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/4/17 AndyG <an...@orprovision.com>

> The users test now passes but I am not sure about pulling in the deps for
> it
> if we were to integrate it into the project.
>
> Is the issue 'org.apache.deltaspike' specific, or do we have something else
> we can use for a test already?
>
> I'm looking, but I'm sure you have a deeper understanding of the issue that
> will get there more quickly!
>
> Andy.
>
>
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/anyone-to-review-commit-the-ix-in-ApplicationComposers-tp4662301p4662317.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Re: anyone to review/commit the ix in ApplicationComposers?

[AndyG <an...@orprovision.com>]

The users test now passes but I am not sure about pulling in the deps for it
if we were to integrate it into the project.

Is the issue 'org.apache.deltaspike' specific, or do we have something else
we can use for a test already?

I'm looking, but I'm sure you have a deeper understanding of the issue that
will get there more quickly! 

Andy.



--
View this message in context: http://openejb.979440.n4.nabble.com/anyone-to-review-commit-the-ix-in-ApplicationComposers-tp4662301p4662317.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.

Re: anyone to review/commit the ix in ApplicationComposers?

[Romain Manni-Bucau <rm...@gmail.com>]

Thank you Andy

*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/4/17 AndyG <an...@orprovision.com>

> I'll do it now.
>
> Andy.
>
>
>
> --
> View this message in context:
> http://openejb.979440.n4.nabble.com/anyone-to-review-commit-the-ix-in-ApplicationComposers-tp4662301p4662315.html
> Sent from the OpenEJB Dev mailing list archive at Nabble.com.
>

Re: anyone to review/commit the ix in ApplicationComposers?

[AndyG <an...@orprovision.com>]

I'll do it now.

Andy.



--
View this message in context: http://openejb.979440.n4.nabble.com/anyone-to-review-commit-the-ix-in-ApplicationComposers-tp4662301p4662315.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.