You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/13 01:28:46 UTC
[GitHub] [flink-kubernetes-operator] jbusche opened a new pull request, #166: Flink 27211 deployments/finalizers missing for OpenShift Deployment
jbusche opened a new pull request, #166:
URL: https://github.com/apache/flink-kubernetes-operator/pull/166
In issue [27211](https://issues.apache.org/jira/browse/FLINK-27211) found a problem where the Flink operator wouldn't deploy on an OpenShift cluster due to missing finalizers in the role and clusterrole. When the lines are added, then the basic.yaml is able to deploy sucessfully:
```
# oc version
Client Version: 4.8.35
Server Version: 4.8.35
Kubernetes Version: v1.21.8+ee73ea2
# oc get pods
NAME READY STATUS RESTARTS AGE
basic-example-5cc7894895-chxzw 1/1 Running 0 19m
basic-example-taskmanager-1-1 1/1 Running 0 19m
flink-kubernetes-operator-697c4b866b-6jrkt 2/2 Running 0 20m
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] jbusche commented on pull request #166: Flink 27211 deployments/finalizers missing for OpenShift Deployment
Posted by GitBox <gi...@apache.org>.
jbusche commented on PR #166:
URL: https://github.com/apache/flink-kubernetes-operator/pull/166#issuecomment-1098430078
Thank you for reviewing, and for the tip @mbalassi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #166: Flink 27211 deployments/finalizers missing for OpenShift Deployment
Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #166:
URL: https://github.com/apache/flink-kubernetes-operator/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #166: Flink 27211 deployments/finalizers missing for OpenShift Deployment
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #166:
URL: https://github.com/apache/flink-kubernetes-operator/pull/166#issuecomment-1097705865
@jbusche nit best practice: If you prefixs the PR msg with `[FLINK-XXXX]` then it gets automatically with the Jira issue, also I suggest to slightly modify the message to better describe the change:
```
[Flink-27211] Adds deployments/finalizers for OpenShift Deployment
```
I am only giving you this level of feedback since it is your first PR to this repo, no need to modify this one, I will take it into account when merging - just helps us next time. Happy contributing! 😏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org