[GitHub] [flink] ferenc-csaky commented on a diff in pull request #23304: [FLINK-32971][PYTHON] Add pyflink proper development version support

["ferenc-csaky (via GitHub)" <gi...@apache.org>]

ferenc-csaky commented on code in PR #23304:
URL: https://github.com/apache/flink/pull/23304#discussion_r1307380348


##########
flink-python/setup.py:
##########
@@ -252,7 +253,7 @@ def extracted_output_files(base_dir, file_path, output_directory):
                   "is complete, or do this in the flink-python directory of the flink source "
                   "directory.")
             sys.exit(-1)
-    if VERSION.find('dev0') != -1:
+    if re.search('dev.*$', VERSION) is not None:

Review Comment:
   nit: Probably this can be argued, so feel free to ignore but in general I think `if <condition>:` is more readable. (And objectively more concise :)).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org