You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 02:16:22 UTC
[GitHub] [flink] vthinkxie commented on a change in pull request #11542:
[FLINK-16303][rest] Enable retrieval of custom JobManager log files
vthinkxie commented on a change in pull request #11542: [FLINK-16303][rest] Enable retrieval of custom JobManager log files
URL: https://github.com/apache/flink/pull/11542#discussion_r402014092
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
##########
@@ -675,26 +704,6 @@ public WebMonitorEndpoint(
return handlers;
}
- @Nonnull
- private ChannelInboundHandler createStaticFileHandler(
- Time timeout,
- File fileToServe) {
-
- if (fileToServe == null) {
- return new ConstantTextHandler("(file unavailable)");
Review comment:
https://github.com/apache/flink/blob/d39f5b33221c813e6b9478001675cb56cf361236/flink-runtime-web/web-dashboard/src/app/app.interceptor.ts#L38
it could work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services