[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #7020: Changed compat tester to make yaml files optional

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #7020:
URL: https://github.com/apache/incubator-pinot/pull/7020#discussion_r645691100



##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -287,90 +287,120 @@ fi
 
 # Setup initial cluster with olderCommit and do rolling upgrade
 # Provide abspath of filepath to $COMPAT_TESTER
+echo "Setting up cluster before upgrade"
 startServices "$oldTargetDir"
 
-echo "Setting up cluster before upgrade"
-$COMPAT_TESTER $testSuiteDir/pre-controller-upgrade.yaml 1
-if [ $? -ne 0 ]; then
-  if [ $keepClusterOnFailure == "false" ]; then
-    stopServices
+genNum=0
+if [ -f $testSuiteDir/pre-controller-upgrade.yaml ]; then

Review comment:
       I don't see any gain in that. Perhaps it is useful to echo a message if there is a missing yaml file (e.g. if "pre-controller-upgrade.yaml missing. Not running any tests"). I can include that in the next PR if you think that is useful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org