You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by ka...@apache.org on 2020/08/02 07:06:43 UTC
[airflow] branch master updated: Fix sensor not providing arguments
for GCSHook (#10074)
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new b79466c Fix sensor not providing arguments for GCSHook (#10074)
b79466c is described below
commit b79466c12f3ae717c31804acc2e9ffcd60f9611c
Author: Kamil Olszewski <34...@users.noreply.github.com>
AuthorDate: Sun Aug 2 09:06:12 2020 +0200
Fix sensor not providing arguments for GCSHook (#10074)
Co-authored-by: Kamil Olszewski <ka...@polidea.com>
---
airflow/providers/google/cloud/sensors/gcs.py | 5 ++++-
tests/providers/google/cloud/sensors/test_gcs.py | 11 +++++++++++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/airflow/providers/google/cloud/sensors/gcs.py b/airflow/providers/google/cloud/sensors/gcs.py
index a32c9cb..07e4f9a 100644
--- a/airflow/providers/google/cloud/sensors/gcs.py
+++ b/airflow/providers/google/cloud/sensors/gcs.py
@@ -259,7 +259,10 @@ class GCSUploadSessionCompleteSensor(BaseSensorOperator):
def _get_gcs_hook(self):
if not self.hook:
- self.hook = GCSHook()
+ self.hook = GCSHook(
+ gcp_conn_id=self.google_cloud_conn_id,
+ delegate_to=self.delegate_to,
+ )
return self.hook
def is_bucket_updated(self, current_objects: Set[str]) -> bool:
diff --git a/tests/providers/google/cloud/sensors/test_gcs.py b/tests/providers/google/cloud/sensors/test_gcs.py
index e353238..0e39c7b 100644
--- a/tests/providers/google/cloud/sensors/test_gcs.py
+++ b/tests/providers/google/cloud/sensors/test_gcs.py
@@ -212,11 +212,22 @@ class TestGCSUploadSessionCompleteSensor(TestCase):
poke_interval=10,
min_objects=1,
allow_delete=False,
+ google_cloud_conn_id=TEST_GCP_CONN_ID,
+ delegate_to=TEST_DELEGATE_TO,
dag=self.dag
)
self.last_mocked_date = datetime(2019, 4, 24, 0, 0, 0)
+ @mock.patch("airflow.providers.google.cloud.sensors.gcs.GCSHook")
+ def test_get_gcs_hook(self, mock_hook):
+ self.sensor._get_gcs_hook()
+ mock_hook.assert_called_once_with(
+ gcp_conn_id=TEST_GCP_CONN_ID,
+ delegate_to=TEST_DELEGATE_TO,
+ )
+ self.assertEqual(mock_hook.return_value, self.sensor.hook)
+
@mock.patch('airflow.providers.google.cloud.sensors.gcs.get_time', mock_time)
def test_files_deleted_between_pokes_throw_error(self):
self.sensor.is_bucket_updated({'a', 'b'})