You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/05/05 13:39:55 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #23949: chore: add codeQL to CI
dpgaspar opened a new pull request, #23949:
URL: https://github.com/apache/superset/pull/23949
### SUMMARY
Add codeQL to our CI workflow.
```
CodeQL is the code analysis engine developed by GitHub to automate security checks. You can analyze your code using CodeQL and display the results as code scanning alerts.
```
Main docs: https://docs.github.com/en/code-security
Will perform code scanning when:
- A PR is merged to master
- A PR is opened -> Results for the PR are available to everyone as annotations
- Daily at 04:00am -> Results are only available to repo writers
For Pull requests:
If you have read permission for a repository, you can see annotations on pull requests. With write permission, you can see detailed information and resolve code scanning alerts for that repository.
Heres an example from a test PR:
<img width="917" alt="Screenshot 2023-05-05 at 14 23 34" src="https://user-images.githubusercontent.com/4025227/236469416-2869ee69-dd20-468c-83d6-b42246bfa0e7.png">
List of common weakness detection: https://codeql.github.com/codeql-query-help/python-cwe/
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #23949: chore: add codeQL to CI
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #23949:
URL: https://github.com/apache/superset/pull/23949#discussion_r1186361008
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -0,0 +1,50 @@
+name: "CodeQL"
+
+on:
+ push:
+ branches: [ "master" ]
+ paths:
+ - 'superset/**'
Review Comment:
it would, javascript and typescript are supported. let's give it a ride first on the backend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #23949: chore: add codeQL to CI
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #23949:
URL: https://github.com/apache/superset/pull/23949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #23949: chore: add codeQL to CI
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #23949:
URL: https://github.com/apache/superset/pull/23949#discussion_r1186285762
##########
.github/workflows/codeql-analysis.yml:
##########
@@ -0,0 +1,50 @@
+name: "CodeQL"
+
+on:
+ push:
+ branches: [ "master" ]
+ paths:
+ - 'superset/**'
Review Comment:
Would it make sense to widen this to the whole codebase? maybe in a subsequent PR, once we've gotten the first part under control?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org