You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Christofer Dutz <ch...@c-ware.de> on 2016/03/18 15:09:04 UTC
[FALCON] Definitely needs some love ...
Hi,
Well I think one thing we definitely need to work on, is making Falcon and FalconJX a lot more robust. During my work on Mavnizing everything I continuously encounter NullPointerExceptions all over the place. It seems that most of the code seems to currently work if everything is correct, but fail miserably with NullPointers if you are not 100% correct. Guess this will cause a lot of frustration with our users.
Chris
Re: [FALCON] Definitely needs some love ...
Posted by Alex Harui <ah...@adobe.com>.
On 3/18/16, 7:09 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi,
>
>
>Well I think one thing we definitely need to work on, is making Falcon
>and FalconJX a lot more robust. During my work on Mavnizing everything I
>continuously encounter NullPointerExceptions all over the place. It seems
>that most of the code seems to currently work if everything is correct,
>but fail miserably with NullPointers if you are not 100% correct. Guess
>this will cause a lot of frustration with our users.
I'm sure there are still plenty of bugs to be fixed. We welcome your help
in this regard. And any other volunteers as well.
Thanks,
-Alex
Re: [FALCON] Definitely needs some love ...
Posted by Michael Schmalle <te...@gmail.com>.
Yes and at the complexity of the transpiler and amount of people that have
actually touched the code, it's all understandable.
When I started that project, I actually used the strategy of unit testing
pretty much every AS statement and expression to produce valid AS, I didn't
even think about JS production in the beginning.
Once the GOOG emitter was started and things got complex, the standard
100's of unit tests I wrote became mute.
IMHO I think th unit tests right now are a mess only due to the fact that
if you realized something was wrong in the impl it might be an actual pain
in the ass to fix it because there is so many things dependent on each
other.
And yeah, there is not a lot of course correction in the logic and it was
brute force from the beginning to get something that actually was close to
working.
Mike
On Fri, Mar 18, 2016 at 3:06 PM, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi Josh,
>
> the problem is that sometimes I can't even say what's the cause of the
> npes. Most of them occured inside the compiler and from the context
> variables I can only guess what's going on. And I would probably have to
> open a big 2 digit number of issues, I would like to prevent that. I guess
> as soon as I have ported things to maven I can start using some of my
> static code analysis tools and start mass-producing test-cases ;-)
>
> But I would like to suggest to start thinking about the case that people
> do things wrong. FlexJS works well if you are on the correct path, but the
> code currently simply can't cope well with errors.
>
> Chris
>
> ________________________________________
> Von: Josh Tynjala <jo...@gmail.com>
> Gesendet: Freitag, 18. März 2016 15:59
> An: dev@flex.apache.org
> Betreff: Re: [FALCON] Definitely needs some love ...
>
> I think the first step is documenting these null pointer exceptions as they
> are encountered. Opening bug reports in JIRA seems like the right course of
> action.
>
> - Josh
>
> On Fri, Mar 18, 2016 at 7:09 AM, Christofer Dutz <
> christofer.dutz@c-ware.de>
> wrote:
>
> > Hi,
> >
> >
> > Well I think one thing we definitely need to work on, is making Falcon
> and
> > FalconJX a lot more robust. During my work on Mavnizing everything I
> > continuously encounter NullPointerExceptions all over the place. It seems
> > that most of the code seems to currently work if everything is correct,
> but
> > fail miserably with NullPointers if you are not 100% correct. Guess this
> > will cause a lot of frustration with our users.
> >
> >
> > Chris
> >
>
AW: [FALCON] Definitely needs some love ...
Posted by Christofer Dutz <ch...@c-ware.de>.
Currently I am trying to get things to work. The problem is that I can't tell what's causing the problems and I keep on setting Exception breakpoints and going up the stack to fin out what's going wrong. It's almost impossible to actually pin down the area of failure ... if I could find out I wouldn't have to dig that deep and that's my main pain in the migration.
Chris
________________________________________
Von: Josh Tynjala <jo...@gmail.com>
Gesendet: Freitag, 18. März 2016 20:23
An: dev@flex.apache.org
Betreff: Re: [FALCON] Definitely needs some love ...
It wasn't my intention to have you try to figure out exactly where and why
the exceptions are being thrown. I was thinking that if you could reliably
reproduce an exception with some ActionScript code, putting that code into
a bug report would be a good enough first step. That provides a foundation
for anyone to investigate further.
Personally, I don't want to poke and prod the compiler with random
malformed code until I find an exception. I'd rather take some existing
code that I know will fail and start with that.
- Josh
On Fri, Mar 18, 2016 at 12:06 PM, Christofer Dutz <christofer.dutz@c-ware.de
> wrote:
> Hi Josh,
>
> the problem is that sometimes I can't even say what's the cause of the
> npes. Most of them occured inside the compiler and from the context
> variables I can only guess what's going on. And I would probably have to
> open a big 2 digit number of issues, I would like to prevent that. I guess
> as soon as I have ported things to maven I can start using some of my
> static code analysis tools and start mass-producing test-cases ;-)
>
> But I would like to suggest to start thinking about the case that people
> do things wrong. FlexJS works well if you are on the correct path, but the
> code currently simply can't cope well with errors.
>
> Chris
>
> ________________________________________
> Von: Josh Tynjala <jo...@gmail.com>
> Gesendet: Freitag, 18. März 2016 15:59
> An: dev@flex.apache.org
> Betreff: Re: [FALCON] Definitely needs some love ...
>
> I think the first step is documenting these null pointer exceptions as they
> are encountered. Opening bug reports in JIRA seems like the right course of
> action.
>
> - Josh
>
> On Fri, Mar 18, 2016 at 7:09 AM, Christofer Dutz <
> christofer.dutz@c-ware.de>
> wrote:
>
> > Hi,
> >
> >
> > Well I think one thing we definitely need to work on, is making Falcon
> and
> > FalconJX a lot more robust. During my work on Mavnizing everything I
> > continuously encounter NullPointerExceptions all over the place. It seems
> > that most of the code seems to currently work if everything is correct,
> but
> > fail miserably with NullPointers if you are not 100% correct. Guess this
> > will cause a lot of frustration with our users.
> >
> >
> > Chris
> >
>
Re: [FALCON] Definitely needs some love ...
Posted by Josh Tynjala <jo...@gmail.com>.
It wasn't my intention to have you try to figure out exactly where and why
the exceptions are being thrown. I was thinking that if you could reliably
reproduce an exception with some ActionScript code, putting that code into
a bug report would be a good enough first step. That provides a foundation
for anyone to investigate further.
Personally, I don't want to poke and prod the compiler with random
malformed code until I find an exception. I'd rather take some existing
code that I know will fail and start with that.
- Josh
On Fri, Mar 18, 2016 at 12:06 PM, Christofer Dutz <christofer.dutz@c-ware.de
> wrote:
> Hi Josh,
>
> the problem is that sometimes I can't even say what's the cause of the
> npes. Most of them occured inside the compiler and from the context
> variables I can only guess what's going on. And I would probably have to
> open a big 2 digit number of issues, I would like to prevent that. I guess
> as soon as I have ported things to maven I can start using some of my
> static code analysis tools and start mass-producing test-cases ;-)
>
> But I would like to suggest to start thinking about the case that people
> do things wrong. FlexJS works well if you are on the correct path, but the
> code currently simply can't cope well with errors.
>
> Chris
>
> ________________________________________
> Von: Josh Tynjala <jo...@gmail.com>
> Gesendet: Freitag, 18. März 2016 15:59
> An: dev@flex.apache.org
> Betreff: Re: [FALCON] Definitely needs some love ...
>
> I think the first step is documenting these null pointer exceptions as they
> are encountered. Opening bug reports in JIRA seems like the right course of
> action.
>
> - Josh
>
> On Fri, Mar 18, 2016 at 7:09 AM, Christofer Dutz <
> christofer.dutz@c-ware.de>
> wrote:
>
> > Hi,
> >
> >
> > Well I think one thing we definitely need to work on, is making Falcon
> and
> > FalconJX a lot more robust. During my work on Mavnizing everything I
> > continuously encounter NullPointerExceptions all over the place. It seems
> > that most of the code seems to currently work if everything is correct,
> but
> > fail miserably with NullPointers if you are not 100% correct. Guess this
> > will cause a lot of frustration with our users.
> >
> >
> > Chris
> >
>
AW: [FALCON] Definitely needs some love ...
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Josh,
the problem is that sometimes I can't even say what's the cause of the npes. Most of them occured inside the compiler and from the context variables I can only guess what's going on. And I would probably have to open a big 2 digit number of issues, I would like to prevent that. I guess as soon as I have ported things to maven I can start using some of my static code analysis tools and start mass-producing test-cases ;-)
But I would like to suggest to start thinking about the case that people do things wrong. FlexJS works well if you are on the correct path, but the code currently simply can't cope well with errors.
Chris
________________________________________
Von: Josh Tynjala <jo...@gmail.com>
Gesendet: Freitag, 18. März 2016 15:59
An: dev@flex.apache.org
Betreff: Re: [FALCON] Definitely needs some love ...
I think the first step is documenting these null pointer exceptions as they
are encountered. Opening bug reports in JIRA seems like the right course of
action.
- Josh
On Fri, Mar 18, 2016 at 7:09 AM, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi,
>
>
> Well I think one thing we definitely need to work on, is making Falcon and
> FalconJX a lot more robust. During my work on Mavnizing everything I
> continuously encounter NullPointerExceptions all over the place. It seems
> that most of the code seems to currently work if everything is correct, but
> fail miserably with NullPointers if you are not 100% correct. Guess this
> will cause a lot of frustration with our users.
>
>
> Chris
>
Re: [FALCON] Definitely needs some love ...
Posted by Josh Tynjala <jo...@gmail.com>.
I think the first step is documenting these null pointer exceptions as they
are encountered. Opening bug reports in JIRA seems like the right course of
action.
- Josh
On Fri, Mar 18, 2016 at 7:09 AM, Christofer Dutz <ch...@c-ware.de>
wrote:
> Hi,
>
>
> Well I think one thing we definitely need to work on, is making Falcon and
> FalconJX a lot more robust. During my work on Mavnizing everything I
> continuously encounter NullPointerExceptions all over the place. It seems
> that most of the code seems to currently work if everything is correct, but
> fail miserably with NullPointers if you are not 100% correct. Guess this
> will cause a lot of frustration with our users.
>
>
> Chris
>