[jira] Issue Comment Edited: (CXF-2474) DocLiteralInInterceptor.handleMessage(Message) does not handle use case where message part is an XMLStreamReader

["Michael Allman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766472#action_12766472 ] 

Michael Allman edited comment on CXF-2474 at 10/16/09 1:37 AM:
---------------------------------------------------------------

Daniel,

I can't use the SourceDataBinding.  Its DataWriter does not handle the case where the object to write is an instance of XMLStreamWriterCallback.  My invoke method returns an object of that type.  That's one reason I'm not using JAX-WS in the first place, but that's a different story...

Can you elaborate on the "StaxDatabinding feature thing that removes those interceptors" as I don't know what that is?

Cheers.

      was (Author: msa@allman.ms):
    Daniel,

I can't use the SourceDataBinding.  It's DataWriter does not handle the case where the object to write is an instance of XMLStreamWriterCallback.  My invoke method returns an object of that type.  That's one reason I'm not using JAX-WS in the first place, but that's a different story...

Can you elaborate on the "StaxDatabinding feature thing that removes those interceptors" as I don't know what that is?

Cheers.
  
> DocLiteralInInterceptor.handleMessage(Message) does not handle use case where message part is an XMLStreamReader
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-2474
>                 URL: https://issues.apache.org/jira/browse/CXF-2474
>             Project: CXF
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.2.4, 2.2.5
>            Reporter: Michael Allman
>            Assignee: Daniel Kulp
>             Fix For: 2.2.5
>
>         Attachments: DocLiteralInInterceptor.patch
>
>
> The DocLiteralInInterceptor.handleMessage(Message) method breaks on the use case where the message part is an XMLStreamReader.
> The code seems to assume that line 188:
>                     o = dr.read(p, xmlReader);
> actually "reads" the message XML from xmlReader and advances to the next message part.  Not so when dr is an XMLStreamDataReader.  In that case, o is in fact xmlReader itself.
> We need to check in the while condition at line 195 that o != xmlReader (or come up with a more elegant solution).  I'm attaching a patch that does that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.